rbardini / resumed Goto Github PK

Hi there, it's the first time I'm trying out https://github.com/rbardini/resumed/tree/master/examples/with-pdf-export so forgive me as I'm a beginner. I get the following error but not sure what I've done wrong, any help is appreciated.

user@thinkpad:~/Downloads/testing/test$ npm start

> start
> node index.js

file:///home/user/Downloads/testing/test/index.js:6
const resume = JSON.parse(await fs.readFile('resume.json', 'utf-8'))
                          ^^^^^

SyntaxError: Unexpected reserved word
    at Loader.moduleStrategy (internal/modules/esm/translators.js:133:18)
    at async link (internal/modules/esm/module_job.js:42:21)
user@thinkpad:~/Downloads/testing/test$ 

Heya,

I'm the author of https://github.com/TaserudConsulting/jsonresume-nix that uses nix to package jsonresume themes and uses resumed to do reproducible builds of resumes. It recently came to my attention in the form of a Pull Request (TaserudConsulting/jsonresume-nix#3) that the meta.canonical URL that I used in my samples were wrong. This was interesting to me since I had just used resumed init to get my sample.

So I dug a bit further, this package depends on resume-schema of version 1.0.0. The filename of the schema in 1.0.0 was resume.json on the master branch. However, after the release of 1.0.0 they have changed this filename on master to schema.json. However... they haven't made a new release of `resume-schema.

So as I see it, there's two things that needs to be done:

1. resume-schema must tag a new release
2. resumed can update this dependency and tag a new release

I will also report this to json-resume.

resumed init myresume.json
file:///usr/local/lib/node_modules/resumed/dist/resumed.js:8
await s(new URL(y, import.meta.url), "utf-8")
^^^^^

SyntaxError: Unexpected reserved word
at Loader.moduleStrategy (internal/modules/esm/translators.js:133:18)

To get resumed to work on the CLI, I had to install it globally.

      - name: Export resume as HTML
        run: |
          npm install resumed -g
          npm install jsonresume-theme-even
          npm audit fix        
          resumed validate resume.json
          resumed render resume.json --theme even --output index.html

My GitHub pipeline is failing to load the Even theme.

https://github.com/jasonpatrickellykrause/jasonpatrickellykrause.github.io/actions/runs/4722875572/jobs/8378060651#step:3:20

Run npm update -g npm --no-fund
  npm update -g npm --no-fund
  npm install resumed -g --no-fund
  npm install jsonresume-theme-even -g --no-fund
  npm root
  npm root -g
  resumed validate resume.json
  resumed render resume.json --theme even --output index.html
  shell: /usr/bin/bash -e {0}

removed 1 package, and changed 43 packages in 10s

added 10 packages in 1s

added 16 packages in [2](https://github.com/jasonpatrickellykrause/jasonpatrickellykrause.github.io/actions/runs/4722875572/jobs/8378060651#step:3:2)s
/home/runner/work/jasonpatrickellykrause.github.io/jasonpatrickellykrause.github.io/node_modules
/usr/local/lib/node_modules
Your resume.json looks amazing! ✨
Could not load theme even. Is it installed?
Error: Process completed with exit code 1.

I am guessing I need to specify the path to the theme, but I have not been able to figure that out. 🤷🏽

As shown in the example, pdf export is pretty straightforward with puppeteer. Considering that many themes do have some PDF export parameters (as resume-cli allowed it), and that PDF is the de-facto standard to share your resume, I think this feature deserves first party support in a resume exporting tool.

I am willing to open a pull request for this, if you'd like.