Giter VIP home page Giter VIP logo

battleground-win-conditions's Introduction

Battleground Win Conditions

Credits:

  • AB Win Conditions for WoTLK which was the original (now outdated for this code) base logic for reference: https://wago.io/lXPWRRs8A
  • Capping addon for code reference to timers and performant base + score updates: https://www.curseforge.com/wow/addons/capping-bg-timers
  • Hazal and the OG Custom Capping addon that had future win info in it to use for reference, along with his direct help in this new work
  • Diminish for code reference on addon structure and best practices: https://www.curseforge.com/wow/addons/diminish
  • ALL of the people who directly helped me test this over the past few months and sent vods and screenshots for bugs and feature ideas

battleground-win-conditions's People

Contributors

rbgdevx avatar

Watchers

 avatar

battleground-win-conditions's Issues

Add flag map features

Currently there is no flag map feature support, and this should mark the tracking for those new features

  • Current Stacks
  • Next stack timer
  • Healing received reduction %
  • Damage taken increase %

Leaving a game doesn't clear the info

I noticed that when leaving an RBG mid-game while the rest of my team was inside the info stayed on the screen and didn't clear.

I'd except that if i left a game it should clear.

Win Condition Info sometimes doesn't match

I noticed once that the amount of bases it said you needed and the time you needed it in was changed after the incoming base from the enemy capped over.

Example
Alliance had 2 with 1 incoming, Horde had 1.

It said we needed 4 near the end of the bases cap over time with 2min left, however when the alliance base capped over it went back to saying we needed 3 in 10 seconds.

That info should be the same and line up at all times and not switch up unless there is base change during that time.

Info from right after they capped the 3rd base:
Screenshot 2023-12-13 105507

Now after my timer ended to get a 3rd base by which was only like 10 seconds, it says we need 4 in 2min:
image

Now when that 3rd base caps over it goes back to saying we need 3 again:
image

I'd expect what i'd need to get to be set and persist and stay matched from the moment the 3d base gets capped to capped over and owned.

Test Data During Cap:
Alliance:

  • Score: 995
  • Owned Bases: 2
  • Incoming Bases: 1, 58 seconds left on base timer

Horde:

  • Score: 945
  • Owned Bases: 1
  • Incoming Bases: 0

Test Data After Cap:
Alliance:

  • Score: 1041
  • Owned Bases: 3
  • Incoming Bases: 0

Horde:

  • Score: 975
  • Owned Bases: 1
  • Incoming Bases: 0

Doesn't handle TIE games

Currently there is no code written to handle TIE games, I'd expect at least some information to be shown to handle this so the users know.

EOTS didn't update correctly

After getting 3 capped in EOTS i noticed that the info still said we won even after their 3rd base capped over, which was incorrect and we lose at that point.

During Cap:
image

After Cap:
image

Add support for showing Win Text only

Right now you can either only show the banner or both the banner and win text, you should add support for also only showing the win text with no banner.

Create an option to allow for Banner only

It would be super cool if you could create an option to only show the win banner that would hide the win info, this new option would provide the users with similar capabilities as the weakaura where there are 2 separate weakauras 1 that has everything and 1 that is just the banner so would be cool if the addon could do that as well.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.