Removing react-navigation-types-only about hooks HOT 9 CLOSED

sure @slorber

from hooks.

@horacioh there is nothing there, all the work is done locally.

What I had been done is read each file line by line and adding typedefs, helped by Visual Studio Code ts compiler and linter.

I have not created types from scratch but try to reuse existing from flow types and @types/react-navigation. Is being very hard pair this types with existing function signatures. In the process some js code has changed, some files are added and others moved.

With this scenario it is difficult to share task with a remote developer. That's why I've been doing it alone.

My plan is create a very opinionated PR to react-navigation core and make the changes that maintainers request. At this point I will need your help for review the commits and contribute on all is left behind and the huge effort of migrate the others react-navigation projects.

I glad you want collaborate on this.

Keep in touch.

from hooks.

types are now in react-navigation (even if core is not yet typed, afaik), so this PR will remove the react-navigation-types-only + align the TS setup with other react-navigation projects

from hooks.

@ericvicenti like I say here https://github.com/react-navigation/react-navigation-core/issues/2.
I'm working a TS rewrite of the core. When finish I will update react-navigation-hooks.

react-navigation-types-only is the a fork of this PR: react-navigation/react-navigation#5276 and have the latest definitions. @types/react-navigation is a little outdate right now.

from hooks.

hey @bySabi!

I see that you are doing things here

maybe we can talk about your strategy and we can start working together on this?

thanks!

from hooks.

perfect @bySabi !
let's keep in touch!

from hooks.

Hi

let me know when you have a stable version so that i can provide feedback

from hooks.

I didn't find any react-navigation-types-only on NPM.

from hooks.

in 1.0.2-alpha.0 the types are retrieved directly from react-navigation. For now they are mostly hand written (afaik) but sooner or later react-navigation core will be in typescript

from hooks.