reactive-python / reactpy-jupyter Goto Github PK

View Code? Open in Web Editor NEW

66.0 4.0 7.0 445 KB

It's React, but in Jupyter

License: MIT License

Python 55.21% JavaScript 12.87% Jupyter Notebook 31.80% Shell 0.11%

jupyter jupyter-lab jupyter-widgets reactpy

reactpy-jupyter's People

Contributors

Stargazers

Watchers

Forkers

pombreda koreanwglasses toorrepus manzt bzbwqz dbouquin olafgroth

reactpy-jupyter's Issues

Widgets not displaying

Hey,

After recent release of idom==0.36.3 i updated my environment and all components stopped working in JupyterLab (even simple example from readme file).
They're simply not displaying and in the browser console, following error is logged:

After downgrading idom to version 0.36.2, everything started working fine.

I've just started playing with idom (i love it!) so i'm afraid i'm not able to help you guys figure out what's wrong.

Cheers!

Doesn't Work In JupyterLab

I'm not really sure why at the moment...

Different version of React used with installed modules

We're using two different instances of React - one in the widget via idomClientReact.mountLayout and the other inside any user-installed modules (e.g. material-ui). This is the same issue we found in idom-dash: idom-team/idom-dash#6

Importing JS Libraries is Broken

There's several issues:

Server-sider IDOM doesn't know where to place installed JS modules so Jupyter can serve them up.
Client-side IDOM doesn't know where installed JS modules are being served.
Dynamically installed modules need to use the same React instance as IDOM... this one I don't really know how to solve. Continued below...

Since the React being used presently by the widget is bundled up and not immediately accessible I wonder if we need to do something completely different. That is, distribute the IDOM client separately from the Jupyter Widget... I need to learn more about this though.

Pip install impossible due to version conflicts

Hello,

While attempting to install idom-jupyter via pip, I encountered the following error:

$ pipenv install idom_jupyter
Installing idom_jupyter…
Collecting idom-jupyter
  Using cached idom_jupyter-0.7.6-py2.py3-none-any.whl (1.6 MB)
  Using cached idom_jupyter-0.7.5-py2.py3-none-any.whl (1.6 MB)
Collecting appdirs
  Using cached appdirs-1.4.4-py2.py3-none-any.whl (9.6 kB)
Collecting requests
  Using cached requests-2.27.1-py2.py3-none-any.whl (63 kB)
Collecting idom-jupyter
  Using cached idom_jupyter-0.7.4-py2.py3-none-any.whl (1.6 MB)
  Using cached idom_jupyter-0.7.3-py2.py3-none-any.whl (1.6 MB)
  Using cached idom_jupyter-0.7.2-py2.py3-none-any.whl (1.6 MB)
  Using cached idom_jupyter-0.7.1-py2.py3-none-any.whl (1.6 MB)
  Using cached idom_jupyter-0.7.0-py2.py3-none-any.whl (1.6 MB)
  Using cached idom_jupyter-0.6.5-py2.py3-none-any.whl (1.5 MB)
  Using cached idom_jupyter-0.6.4-py2.py3-none-any.whl (1.5 MB)
  Using cached idom_jupyter-0.6.3-py2.py3-none-any.whl (1.5 MB)
  Using cached idom_jupyter-0.6.2-py2.py3-none-any.whl (1.5 MB)
  Using cached idom_jupyter-0.6.1-py2.py3-none-any.whl (1.5 MB)
  Using cached idom_jupyter-0.6.0-py2.py3-none-any.whl (1.5 MB)
  Using cached idom_jupyter-0.5.2-py2.py3-none-any.whl (233 kB)
  Using cached idom_jupyter-0.5.1-py2.py3-none-any.whl (233 kB)
  Using cached idom_jupyter-0.5.0-py2.py3-none-any.whl (233 kB)
  Using cached idom_jupyter-0.4.0-py2.py3-none-any.whl (233 kB)
  Using cached idom_jupyter-0.2.0-py2.py3-none-any.whl (2.2 MB)
  Using cached idom_jupyter-0.1.1-py2.py3-none-any.whl (1.6 MB)
  Using cached idom_jupyter-0.1.0-py2.py3-none-any.whl (1.6 MB)

The conflict is caused by:
    idom-jupyter 0.7.6 depends on idom<0.39 and >=0.38.1
    idom-jupyter 0.7.5 depends on idom<0.37 and >=0.36.0
    idom-jupyter 0.7.4 depends on idom<0.37 and >=0.36.0
    idom-jupyter 0.7.3 depends on idom<0.37 and >=0.36.0
    idom-jupyter 0.7.2 depends on idom<0.37 and >=0.36.0
    idom-jupyter 0.7.1 depends on idom<0.37 and >=0.36.0
    idom-jupyter 0.7.0 depends on idom<0.37 and >=0.36.0
    idom-jupyter 0.6.5 depends on idom<0.37 and >=0.36.0
    idom-jupyter 0.6.4 depends on idom<0.36 and >=0.35.4
    idom-jupyter 0.6.3 depends on idom<0.36 and >=0.34.0
    idom-jupyter 0.6.2 depends on idom<0.34 and >=0.33.0
    idom-jupyter 0.6.1 depends on idom<0.34 and >=0.33.0
    idom-jupyter 0.6.0 depends on idom<0.32 and >=0.31.0
    idom-jupyter 0.5.2 depends on idom<0.24 and >=0.23
    idom-jupyter 0.5.1 depends on idom>=0.22.2
    idom-jupyter 0.5.0 depends on idom>=0.22.2
    idom-jupyter 0.4.0 depends on idom>=0.20.1
    idom-jupyter 0.2.0 depends on idom>=0.17.1
    idom-jupyter 0.1.1 depends on idom>=0.15.0
    idom-jupyter 0.1.0 depends on idom>=0.13.0

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict


Error:  An error occurred while installing idom_jupyter!
ERROR: Cannot install idom-jupyter==0.1.0, idom-jupyter==0.1.1, idom-jupyter==0.2.0, idom-jupyter==0.4.0, idom-jupyter==0.5.0, idom-jupyter==0.5.1, idom-jupyter==0.5.2, idom-jupyter==0.6.0, idom-jupyter==0.6.1, idom-jupyter==0.6.2, idom-jupyter==0.6.3, idom-jupyter==0.6.4, idom-jupyter==0.6.5, idom-jupyter==0.7.0, idom-jupyter==0.7.1, idom-jupyter==0.7.2, idom-jupyter==0.7.3, idom-jupyter==0.7.4, idom-jupyter==0.7.5 and idom-jupyter==0.7.6 because these package versions have conflicting dependencies.
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies

I was able to install idom itself.

Any help would be appreciated.

Remove Extra JS

It looks like these are no longer needed: https://github.com/idom-team/idom-jupyter/blob/8b40214450618a47190213019f7eded287c0dff3/js/lib/widget.js#L123-L124

Log idom_jupyter version to console

This will make it easier to debug issues reported by users

Add type annotations

Currently there are not type annotations. While not critical it makes it easier to follow the logic for future contributors.

Model class 'IdomModel' from module 'idom-client-jupyter' is loaded but can not be instantiated

Launching binder notebook using the link from README results in the following error after executing cells.

[Open Browser Console for more detailed log - Double click to close this message]
Model class 'IdomModel' from module 'idom-client-jupyter' is loaded but can not be instantiated
TypeError: o._deserialize_state is not a function
    at u._make_model (https://hub.ovh2.mybinder.org/user/idom-team-idom-jupyter-lw0tbzbx/nbextensions/jupyter-js-widgets/extension.js?v=20221223025821:2:747339)

build logs:

Found built image, launching...
Launching server...
Server requested
2022-12-23T03:40:51.256234Z [Normal] Successfully assigned ovh2/jupyter-idom-2dteam-2didom-2djupyter-2d15jeanpl to user-202211a-node-c616e7
2022-12-23T03:40:52Z [Normal] Container image "jupyterhub/mybinder.org-tc-init:2020.12.4-0.dev.git.4289.h140cef5" already present on machine
2022-12-23T03:40:52Z [Normal] Created container tc-init
2022-12-23T03:40:52Z [Normal] Started container tc-init
2022-12-23T03:40:53Z [Normal] Pulling image "2lmrrh8f.gra7.container-registry.ovh.net/mybinder-builds/r2d-g5b5b759idom-2dteam-2didom-2djupyter-67cfe6:276e3ada3bcbff2f8254c2fa339ee3aeaf9b2b1e"
2022-12-23T03:41:46Z [Normal] Successfully pulled image "2lmrrh8f.gra7.container-registry.ovh.net/mybinder-builds/r2d-g5b5b759idom-2dteam-2didom-2djupyter-67cfe6:276e3ada3bcbff2f8254c2fa339ee3aeaf9b2b1e" in 53.041814721s
2022-12-23T03:41:46Z [Normal] Created container notebook
2022-12-23T03:41:47Z [Normal] Started container notebook

Add license to setup.py and LICENSE file

I'm interested in experimenting with this at work but our build process requires that we check the license of all code that is imported. I noticed that idom is licensed as "MIT" in setup.py and includes a LICENSE file. Would you be willing to do that for idom-jupyter as well?