readium / r2-shared-kotlin Goto Github PK

It was added some time ago to the model, implemented on iOS.

I suppose that problem from shared lib. What is wrong ?

Looks like the current code expects an array of objects: https://github.com/readium/r2-shared-kotlin/blob/develop/r2-shared/src/main/java/org/readium/r2/shared/Metadata.kt#L157

But subjects can be simply expressed using strings as well (either a single string, or an array of strings) as seen in: https://test.opds.io/2.0/publications.json

Used as an internal in Swift and Kotlin for parsing
Shouldn't be part of the core model
Might be better using a cascade instead for parsing

Implement UserSettings model into r2-shared-kotlin

Added subtitle
Added duration
Added numberOfPages
Extended list of contributors
spine became readingOrder
direction became readingProgression
sort-as became sortAs
belongs-to became belongsTo

In the current code, the parser expects an object for metadata-level links: https://github.com/readium/r2-shared-kotlin/blob/develop/r2-shared/src/main/java/org/readium/r2/shared/Contributor.kt#L81

This is incorrect, links will always be an array in our model: https://github.com/readium/webpub-manifest/blob/master/schema/contributor-object.schema.json#L41

This can be tested using the OPDS 2.0 Test Catalog at https://test.opds.io/2.0/publications.json