readium / r2-shared-swift Goto Github PK

Added subtitle
Added duration
Added numberOfPages
Extended list of contributors
spine became readingOrder
direction became readingProgression
sort-as became sortAs
belongs-to became belongsTo

https://developer.apple.com/documentation/foundation/archives_and_serialization/encoding_and_decoding_custom_types
https://benscheirman.com/2017/06/swift-json/

OPDS 2 parser throws an error with this author key:

"metadata": {
  "@type": "http://schema.org/Book",
  "title": "Le Rouge et le Noir",
  "subtitle": "Chronique du XIXe siècle",
  "sort_as": "Rouge et le Noir, Le",
  "author": ["Stendhal", "Second Name For Testing"],
  [...]
}

RWPM now supports a conformsTo property to identify a RWP profile, see readium/webpub-manifest#72

We need to support it in the shared models and in the media type sniffers.

With the upcoming PR (#13), we'll now be able to parse the RWPM manifest to transform it into our in-memory structure.

For now this is mostly used for OPDS 2.0, where it seems to be broken.

This can be tested in the Test App using the OPDS 2.0 Test Catalog: https://feedbooks.github.io/opds-test-catalog/opds-2/home.json

More specifically, the publications feed is meant to test as many edge cases as possible: https://feedbooks.github.io/opds-test-catalog/opds-2/publications.json

This Epic will probably have to remain open for some time, as we gradually add more test cases and related issues to it.

numberOfItems properties are not correctly set (used in navigation table view, in facets view, etc.).

I have been trying to run my project after updating the Carthage and it gives me the error saying that Drm.profile is a get only property. My code was working fine before this new commit. I am waiting to release my app on AppStore and not able to do so because of this. Can you let me know which previous version is compatible where Drm.profile is not only a get property. I tried with previous 3-4 commits but it gives me the following error-
Could not pick a version for github "Readium/r2-shared-swift", due to mutually incompatible requirements:
"41603fa5b7e6b960e490b2a5c7f8d9b6a77bc731"
"develop" (github "readium/readium-opds-swift")

OPDS 2 parser throws OPDS2ParserError.invalidCollection with this links key:

OPDS 2 parser throws an error with this price key:

"links": [
  {
    "rel": "http://opds-spec.org/acquisition/buy", 
    "href": "https://feedbooks.github.io/opds-test-catalog/assets/chambrejaune/file.epub", 
    "type": "application/epub+zip",
    "properties": {
      "price": {
        "currency": "USD",
        "value": 4.99
      }
    }
  }
]

OPDS 2 parser throws OPDS2ParserError.invalidLink.

In order to implement support for the new user settings abstract model, we need to add a new model in this repo based on: https://github.com/readium/readium-2/blob/master/other/user-settings.md#abstract-model

ref, name and value should all be strings.

Publication should contain an array of this new structure using userSettings.

To facilitate things, we might need to create the usual helpers as well:

• getter (based on both ref and name)
• setter (based on both ref and name)

When serializing a Metadata object to JSON, its property belongsTo (and children like Collection) are ignored. Is it an oversight or on purpose?

There's no easy way to check the version of the Readium 2 libs used. We could add a runtime constant to get this info.

Used as an internal in Swift and Kotlin for parsing
Shouldn't be part of the core model
Might be better using a cascade instead for parsing