readleyj / gotracer Goto Github PK

Named fields are not used for creating new objects. Easy to mess up the order.

In the current implementation setting HasShadow to false makes the whole object disappear.

Right now, a world supports a single point light. Would be better to be able to place multiple lights in a scene

The current implementation of IsShadowed considers only the first light in the world's Lights field. Implementation has to be fixed so the multiple lights are taken into account

The naming patterns of functions for creating new objects are inconsistent. Some objects are created with Create, some with New, and some with struct literals. A unified naming pattern for creating new objects would be cleaner

Much of the matrix code is needlessly duplicated. A matrix struct would be more clean at the cost a possible reduction in performance (Because of switch from arrays to slices)
Also, color.go and tuple.go contain both method and function implementations. Sticking to either methods or functions would likely reduce clutter