realkc / kcshot Goto Github PK

This is a nice feature I miss from ShareX.

Blocked on #21, as I want this feature to integrate cleanly into the postcapture action system.

This is a feature both ShareX and ksnip have, and it'd be nice if we got it too as I liked having it.

Some screenshots

Implementations must only make changes to the model (as visible to its consumer) in places that will not cause problems for that consumer. For models that are driven directly by a write API (such as GListStore), changes can be reported in response to uses of that API. For models that represent remote data, changes should only be made from a fresh mainloop dispatch. It is particularly not permitted to make changes in response to a call to the GListModel consumer API.
Stated another way: in general, it is assumed that code making a series of accesses to the model via the API, without returning to the mainloop, and without calling other code, will continue to view the same contents of the model.

(from https://docs.gtk.org/gio/method.ListModel.items_changed.html)

I'll get to this once it's less late/I have time

This would be a system that allows you to execute a series of actions on your screenshot after it was taken, enabling chains such as Capture -> Save -> Edit -> Copy to Clipboard or Capture -> Edit -> Upload to Image Host -> Copy to Clipboard.

More work on them will probably require some refactors on how screenshots get taken, I think.

I think the dropdown makes the editor UI look uglier, though using this approach means the feature is less discoverable. (Having buttons like we do for other actions could work, but I'm having trouble imagining good icons for this)

Context

Currently kcshot uses ksni exclusively to create a systray icon, this only works on systems that have a KDE/freedesktop Status Notifier Item host, which on WMs, means snixembed mostly (at least it does on awesomewm, which is what I use), it'd be nice if this dependency could be dropped.

XEmbed-based solution

This solution would make use of the old (and I imagine deprecated) systray specification, the high level overview of what needs to be done is:

1. Create a window in the systray area using xcb
2. Give ownership of it to gtk
3. Add an image widget and a menu on right click

I, however, have been unable to make this work, my past attempts:

• Attempt 1
• Attempt 2

Alternatives

1. Do nothing, preserve the status quo
2. Make a special systray binary that runs in its own process and uses gtk3+libappindicator. It'd work, but I'm not sure I like this option

The editor currently does a lot more work than needs to be done when receiving draw events, here are some things that could be done to improve the performance:

• Avoid some allocations in editor::pixelops by avoiding the intermediate Pixbufs
• Pull the editor::pixelops code into its own crate and config cargo to enable all optimizations on that one (this is most important for people running kcshot in debug mode -- which I am)
• Figure out a way to cache previously drawn surfaces, so we don't need to execute all operations over and over each draw event

I'll update the issue if more things come to mind.

Currently this is our colour chooser:

This is a pretty limiting colour chooser, something like the following, from ShareX, would be better instead:

Example:

Reproduction is inconsistent, but when it happens it usually repeats consistently for a time till the bug disappears again.

• Create a custom grid view widget for the history in the main panel
  • Currently the standard gtk widgets just load all the items in the model at once, we should make something that only loads viewable items (I think we'd need to manually implement the scrollable interface for this)
• Add a list view that displays file paths, date when screenshot was taken and url that it was uploaded to. It should be accessible through the history button. It should also have a context menu with the same options as the one in the main view
• Hide the history button when history is disabled (eccaf5d)
• All the above widgets should have context menus for their items that allow you to copy images, urls, etc

For instance, if blurring over an ellipse, the colour which should be present is not there.
Example:

Currently our text dialog is pretty bad:

Ideally we'd have a better dialog, that allows for rich text formatting instead of what we currently have

(Opening issue as I don't want to work on this part of the app atm anymore)