Giter VIP home page Giter VIP logo

Comments (9)

RealRaven2000 avatar RealRaven2000 commented on August 16, 2024 1

Can you test this new beta version below:

https://github.com/RealRaven2000/quickFilters/releases/tag/5.0pre67

It should now show the settings correctly and save them after modification and obiviously also not ignore them anymore..

from quickfilters.

RealRaven2000 avatar RealRaven2000 commented on August 16, 2024

the way it should work: these checkboxes are (should be) connected to the global setting so once you check /uncheck them they should remember this as default behavior. Do I understand you correctly that they

  • work during one assistant run
  • do not remember when you uncheck?

from quickfilters.

StuporDaveOsborne avatar StuporDaveOsborne commented on August 16, 2024

The check boxes do not seem to relate to the global settings at all.
I did further testing. I found the config settings and observed that 1: the default for both "editor" and "list""afterCreate" is enabled. However during creation the default "next steps" boxes are unchecked even though the global is enabled. Checking them makes no difference as the steps are already enabled, however UNchecking them also does nothing, the global settings do not change. I have tried this through restarts as well.
I have tested the checkboxes against globals both on & off, even through restarts. They don't over-ride the globals. Let me know if you need anything else.

from quickfilters.

RealRaven2000 avatar RealRaven2000 commented on August 16, 2024

The check boxes do not seem to relate to the global settings at all.
I did further testing. I found the config settings and observed that 1: the default for both "editor" and "list""afterCreate" is enabled. However during creation the default "next steps" boxes are unchecked even though the global is enabled. Checking them makes no difference as the steps are already enabled, however UNchecking them also does nothing, the global settings do not change. I have tried this through restarts as well.
I have tested the checkboxes against globals both on & off, even through restarts. They don't over-ride the globals. Let me know if you need anything else.

So what you're saying is - the checkboxes don't have any effect whatsoever? They are not stored globally, and they do not skip any screens if you uncheck?

from quickfilters.

StuporDaveOsborne avatar StuporDaveOsborne commented on August 16, 2024

That is correct. I did two tests, starting from a restart with "enabled" and checked, I unchecked during creation and still had both popups. Then I did another restart and created another filter (this time the checkboxes were already unchecked from the last filter) and still had both popups. The global config settings were still set to true, no change.

from quickfilters.

RealRaven2000 avatar RealRaven2000 commented on August 16, 2024

That is correct. I did two tests, starting from a restart with "enabled" and checked, I unchecked during creation and still had both popups. Then I did another restart and created another filter (this time the checkboxes were already unchecked from the last filter) and still had both popups. The global config settings were still set to true, no change.

That's actually good news - sounds like the preferences aren't properly "wired up" with the configuration database - it shouldn't be too hard to reproduce / fix for the next beta!

To prioritize, I am going to pin this issue to the top so I won't miss it.

from quickfilters.

StuporDaveOsborne avatar StuporDaveOsborne commented on August 16, 2024

Settings are working correctly now.

from quickfilters.

RealRaven2000 avatar RealRaven2000 commented on August 16, 2024

Settings are working correctly now.

Good stuff. I am going to close the issue once we go live. John Bieling cam up with the initial pattern (a hack overwriting preference id with the name) and it works quite seamlessly giving back the automatic dialog to settings binding that we have grown so used to over the last decade.

from quickfilters.

RealRaven2000 avatar RealRaven2000 commented on August 16, 2024

Fixed in release 5.0

from quickfilters.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.