Using getRelations of SelectFields involves only selecting the requested fields for relationships about graphql-laravel HOT 5 CLOSED

Ok, as soon as I can I elaborate tests and pr.

from graphql-laravel.

Sorry, same answer as in #979 . I try to keep SelectFields alive as best as possible, but TBH I've a hard time maintaining and (and also no fun doing so) and I also never truly used it, dataloaders are preferred.

from graphql-laravel.

Does the https://github.com/rebing/graphql-laravel#eager-loading-relationships always-field mentioned here, fixes it for you?

or the query param?
https://github.com/rebing/graphql-laravel#type-relationship-query

from graphql-laravel.

Hi @crissi, I played with both ways (always field and type relationship query) to get around the problem but in the end it all turned out to be too complicated and logically incorrect (IMO the graphql layer must not be aware of the fields needed for any computed field logics on the eloquent side), so I chose another solution, extend SelectFields class and overwrite the method handleFields.

I disabled this check, so instead of this:

I just left this:

$select = [$parentTable.'.*'];

Doing so I "solved" the problem for me, I hope I was clear and helpful.

from graphql-laravel.

I just remembered this other PR #277, talking about something different but targeting the same area and logic (wasn't merged in the end).

from graphql-laravel.