https://github.com/symfony/symfony/blob/master/UPGRADE-4.0.md

Hi,

I have trouble with run Rector. After creating rector as project (via #46) then I run

rector/bin/rector process /path/to/my-files

Iteration from files was correct (I dumped file names) but it did nothing. Where is the problem, maybe it is in rewrited command?

Hi,

is it on packagist already?
It looks really great, I want test it :)

 [InvalidArgumentException]                                                                                                                     
  Could not find package rector/rector at any version for your minimum-stability (stable). Check the package spelling or your minimum-stability  

Ref https://forum.nette.org/cs/29388-je-nejaka-nahrada-magickych-method

- $this->assertTrue(is_readable($readmeFile), sprintf('Cannot read "%s".', $readmeFile));
+ $this->assertIsReadable($readmeFile, sprintf('Cannot read "%s".', $readmeFile));

   $this->setExpectedExceptionRegExp(
-            \PhpCsFixer\ConfigurationException\InvalidConfigurationException::class,
+        $this->expectException(InvalidConfigurationException::class);
+        $this->expectExceptionMessageRegExp(
             '#^The config file: ".+[\/\\\]Fixtures[\/\\\]ConfigurationResolverConfigFile[\/\\\]case_5[\/\\\]\.php_cs\.dist" does not return a "PhpCsFixer\\\ConfigInterface" instance\. Got: "string"\.$#'
         );

See PHP-CS-Fixer/PHP-CS-Fixer#3182

Ref: https://engineering.facile.it/blog/eng/phpunit-upgrade-namespace/

E.g. Nette\InjectPropertyRector => Nette\DI\InjectPropertyRector

Ref: umpirsky/Symfony-Upgrade-Fixer#23

Before

public function setDefaultOptions(OptionsResolverInterface $resolver) {
    parent::setDefaultOptions($resolver);
}

After:

public function configureOptions(OptionsResolver $resolver) {
    // Parent call renamed as well
    parent::configureOptions($resolver);
}

Useful Checkers

• no unused imporats
• ordered imports
• docblock empty spaces

Faster to bootstrap:

# symfony33.yml
rectors:
    ClassReplacer:
        OldClass: NewClass

It would also make change more transparent and easy to scale - adding new class is now easy.

It's not worth writing custom class and tests, since it only uses AbstractClassReplacerRector over and over again.

What do you think @grogy?

Todo

• document in docs: How to write Rectors → Class or method replacement in config

Before (2.0)

$this->template->registerHelper('texy', callback($texy, 'process'));

Then

# todo

Now

# todo

nette/sandbox@v2.0.0...v2.1.0

Ref https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-4.0.md

Ref Roave/BetterReflection#224 (comment)

Nice to Adopt Feature

Add getFirstAncestor() to NodeFinder

• https://github.com/Microsoft/tolerant-php-parser/search?utf8=✓&q=getFirstAncestor&type=
• Add here https://github.com/nikic/PHP-Parser/blob/e2e99f269b5b543c9196e1cf56348942165e8faf/lib/PhpParser/NodeFinder.php

sebastianbergmann/phpunit@5.7.9...6.0.0

For @shopsys ❤️

Ref: https://github.com/symfony/symfony/blob/master/UPGRADE-3.3.md

• FrameworkBundle classes https://github.com/symfony/symfony/blob/master/UPGRADE-3.3.md#frameworkbundle

• The console.exception event and the related ConsoleExceptionEvent class have been deprecated in favor of the console.error event and the ConsoleErrorEvent class. The deprecated event and class will be removed in 4.0.

• The ContextErrorException class is deprecated. \ErrorException will be used instead in 4.0.

All migration guides in Docs:

Done

• "In PhpGenerator methods setDocuments(), getDocuments() and addDocument() was replaced by setComment(), getComment() and addComment()" - Closed by #12

• "Negative validation rules. An alternative for the ~Form::FILLED is Form::BLANK, or ~Form::EQUAL can be replaced with Form::NOT_EQUAL"

• "Nette\Utils\Html::add() is replaced with addHtml() and addText()" - Closed by #8

Sources

• https://forum.nette.org/cs/26250-pojdte-otestovat-nette-2-4-rc
• https://doc.nette.org/en/2.4/migration-2-1#toc-dependency-injection-di-2
• https://github.com/nette/nette/releases/tag/v2.4.0
• https://doc.nette.org/en/2.4/migration
• https://doc.nette.org/en/2.4/migration-2-4#toc-others

For framework related changes that are not strictly connected with framework versions' BC breaks

• Set: Nette
• Version 2.3 => 2.4
• Related commit: nette/php-generator@9d3d8d4#diff-553ff5a7ad6591c63da96be5cd103826R380

Use AbstractChangeMethodNameRector

Maybe general underscore to slash rector, like php code Sniffer sniff class

See https://github.com/umpirsky/Symfony-Upgrade-Fixer#fixers-available

• symfony30.yml

For use cases like #8

Nette 2.1?

Ref https://github.com/TomasVotruba/Rector/pull/2/files

https://github.com/nikic/PHP-Parser/blob/master/lib/PhpParser/NodeTraverser.php

https://github.com/nikic/PHP-Parser/blob/master/test/PhpParser/NodeTraverserTest.php

Message in the code => propert rector operation

See:

#28 (comment)

Yes, when there is addRule(), there must be setRequired().

The mainstream use case:

Before:

$form->addRule(...);

After

$form->setRequired(true);
    ->addRule(...);

See https://forum.nette.org/cs/29393-doctrine-setentity-is-deprecated

Ref Kdyby/Doctrine@8a90efc#diff-ccc8ba07edfa3a425ddfe564acb50656

to phpunit60.yml

• PhpUnitDedicateAssertFixer

• PhpUnitNoExpectationAnnotationFixer + test

• PhpUnitMockFixer

E.g. Symfony 3.0

The __toString() method of the \Symfony\Component\Config\ConfigCache class was removed in favor of the new getPath() method.

This looks amazing! Really looking forward to testing it. One thing I noticed straight from the README, though. Shouldn't the nette, symfony, etc rectors be in their own repositories? I think it will be a pain, further down the road, to strip them from the main repo and notify everyone to update the dependencies, etc.

Ref https://forum.nette.org/cs/26672-missing-setrequired-true-false-on-field-abc-in-form

To reflect changes like:

"If you write your own extensions, you should know that these namespaces was renamed: Nette\Config → Nette\DI and Nette\Utils\PhpGenerator → Nette\PhpGenerator."

Source: https://doc.nette.org/en/2.4/migration-2-1#toc-dependency-injection-di-2

Ref: https://github.com/nette/nette/blob/v0.9.7/Nette/Environment/Environment.php

With setInject() to setTag() Nette\DI\Definition example

See https://github.com/doctrine/doctrine2/blob/master/UPGRADE.md

I get project with full of problems in codebase. For example how are created dependencies:

  protected function createComponent($name)
  {
    switch ($name)
    {
      // models
      case 'catalog': $this->addComponent(Environment::getService('CatalogModel'), $name); return;
      case 'library': $this->addComponent(Environment::getService('LibraryModel'), $name); return;
      case 'page': $this->addComponent(Environment::getService('PageModel'), $name); return;
      case 'seo': $this->addComponent(Environment::getService('SeoModel'), $name); return;
      case 'shop': $this->addComponent(Environment::getService('ShopModel'), $name); return;
      case 'user': $this->addComponent(Environment::getService('UserModel'), $name); return;

      default:
        return parent::createComponent($name);
    }
  }

and using of dependency:

$this['shop']->getShopSubcategories(..);

Any idea how automaticaly repair this? :-))

use Symfony\Component\DependencyInjection\ContainerBuilder;

$container = new ContainerBuilder();
$container
    ->register('foo', 'stdClass')
    ->setScope(ContainerBuilder::SCOPE_PROTOTYPE)
;

last call into

  ->setShared(false)

E.g.

class MyControl extends Control
{
}

$types = $controlNode->getAttribute(Attribute::TYPES);
dump($types); // ['MyControl', 'Control']

https://github.com/nikic/PHP-Parser/blob/master/lib/PhpParser/BuilderFactory.php

Should cover

• getter
• setter

E.g Symfony 3.0

Before

 class CustomTranslator extends Translator
 {
     public function fooMethod()
     {
        // get locale
        $locale = $this->locale;

        // update locale
        $this->locale = $locale;
     }
 }

After

 class CustomTranslator extends Translator
 {
     public function fooMethod()
     {
        // get locale
        $locale = $this->getLocale();

        // update locale
        $this->setLocale($locale);
    }
 }

After this gets fixed deprecated-packages/symplify#265

I run rector as standalone project. If I run it on my project like this:

php w:\git\rector\bin\rector process src --level symfony40

I get following error

...
 - src\Admin\Media\Image\EntityType.php

...and 356 more.

PHP Notice:  Undefined property: PhpParser\Node\Stmt\Trait_::$extends in W:\git\rector\src\NodeAnalyzer\ClassAnalyzer.php on line 48

Notice: Undefined property: PhpParser\Node\Stmt\Trait_::$extends in W:\git\rector\src\NodeAnalyzer\ClassAnalyzer.php on line 48
PHP Notice:  Undefined property: PhpParser\Node\Stmt\Trait_::$implements in W:\git\rector\src\NodeAnalyzer\ClassAnalyzer.php on line 58

Notice: Undefined property: PhpParser\Node\Stmt\Trait_::$implements in W:\git\rector\src\NodeAnalyzer\ClassAnalyzer.php on line 58
PHP Notice:  Undefined property: PhpParser\Node\Stmt\Interface_::$implements in W:\git\rector\src\NodeAnalyzer\ClassAnalyzer.php on line 58

Notice: Undefined property: PhpParser\Node\Stmt\Interface_::$implements in W:\git\rector\src\NodeAnalyzer\ClassAnalyzer.php on line 58

[Rector\BetterReflection\Reflector\Exception\IdentifierNotFound]
  Rector\BetterReflection\Reflection\ReflectionClass "XY\AppBundle\Sentry\SentryObject" could not be found in the located source

To prevent any install issues, like those report by @EdoBarnas on Windows
Not worth the pain for person who install this package

Before

After

• RouterFactory

• https://forum.nette.org/cs/9971-zkusenosti-z-upgradu-z-0-9-na-2-0
• https://forum.nette.org/en/19357-nette-framework-2-0-final-released
• https://forum.nette.org/en/19356-nette-framework-2-0-rc-released