false positive wordpress noop.php RemoveExtraParametersRector about rector HOT 10 CLOSED

if i get the time ill try and whip up a reproducible repo. This is really bugging me :)

from rector.

@chrillep Thanks for provided files. This is really autoload issue with Wordpress, it loads this file first https://core.trac.wordpress.org/browser/tags/6.4.2/src/wp-admin/includes/noop.php#L18 and then suggests Rector that this method has no arguments.

Not how Rector or PHPStan can be helpful at Wordpress if the autoload is providing false information. Could be dead end by Wordpress design.

Instead I'd suggest to skip rules like RemoveExtraParametersRector using skip() method in rector.php:
https://getrector.com/documentation/ignoring-rules-or-paths

from rector.

Duplicate with #7894

function seems not autoloaded, or too late loaded, you can read the doc for how to solve it https://getrector.com/documentation/static-reflection-and-autoload

from rector.

I dont' understand?
I'ts only happening in CI ?
locally its fine.
the exact same composer commands are ran.
this started happening with
"rector/rector": "^0.18.12",

ill try and get to the bottom of the differences.

in the meantime we are using bedrock and sage which is basicly WP for composer.
So it already autoloads from vendor

https://roots.io/bedrock/
https://roots.io/sage/
https://roots.io/acorn/

from rector.

are you saying i should load all the files needed before the autoloading is done ?
for example l10n.php ?

from rector.

Yes, functions need to be registered as files in composer,

https://stackoverflow.com/questions/24171078/composer-psr-how-to-autoload-functions

On rector use case, you can place under autoload-dev

or you can define custom bootstrap for it.

from rector.

ill try but it still does not explain why it works locally :)

from rector.

yeah, thank u. I used the RemoveExtraParametersRector class.
But for me and my colleagues, its still a conundrum as to why this works locally
without RemoveExtraParametersRector and not in the ci.
Seeing as you are the creator of this repo, ill just use the RemoveExtraParametersRector :).

from rector.

@chrillep That could be caused by autoload order. E.g. I know that Windows, Unix and OSx order same files differently. This is being used by Composer internals and could result in prioritizing one file over another.

from rector.

Aaah ok . Yeah we use OS X locally. And GitHub Ci is Ubuntu/ linux by default .

Thank you for the Peace of mind 🙏

from rector.