Incorrect behaviour of FirstClassCallableRector with __invoke about rector HOT 3 CLOSED

Thanks @samsonasik!

Sorry I forgot to mention the reason I reported it was getting the "Non-static method A::__invoke() cannot be called statically" error.

from rector.

Reproduced at https://getrector.com/demo/cc98f4b3-8054-418d-bc86-3499319ab761

Looking at the result, they seems equivalent between these 3 code when on same object:

• https://3v4l.org/ss6jV ( no change)
• https://3v4l.org/r7Ue7 (with __invoke() call)
• https://3v4l.org/W0012 (with new class usage)

on different object, it sems cause error:

• https://3v4l.org/pHk7S

as caller is not static, the solution is either make it new:

• https://3v4l.org/FEpHj

or just skip it, I think we need to skip it as it maybe a service that require __construct() argument.

from rector.

reproduced at https://getrector.com/demo/4ca36426-9ab7-419c-b418-2ed7fa734623

from rector.