[ERROR] Could not process "vendor/googleads/google-ads-php/src/Google/Ads/GoogleAds/Lib/V16/InfoRedactor.php" file, due about rector HOT 9 CLOSED

The code is scanned by PHPStan as well, and configured to win over old code, we use php8parser:

so crash too early when language not yet available can happen. That's hard to make win both php 7.x and php 8.x, we have e2e test for it:

https://github.com/rectorphp/rector/tree/main/e2e

from rector.

I've narrowed it down to this line

$localServicesLead?->getContactDetails()?->getEmail()

from rector.

Could you reproduce at https://getrector.com/demo ?

from rector.

Nope, it looks like it doesn't change the ?-> (probably related to the fact that my php is 7.4 but in the playground it 8+)

from rector.

That seems working ok https://getrector.com/demo/9b2f0d84-d26e-43fd-bb44-4fec8064a8ec

Could you try create minimal reproducible repo? Thank you.

from rector.

Try to run the code from php 7.4

from rector.

That same, still working, php version can be defined from rector config via withPhpversion(), see https://getrector.com/demo/fcf9f36b-47ba-4339-9815-3adcfb829893

The issue may need to be reproduced by real repository, simple one, otherwise, nothing we can do :)

from rector.

Ok, I got it, it syntax error early, which seems expected, tested with php 7.4 vs php 8.0

PHP 7.4

➜   php74 vendor/bin/rector process test.php --dry-run
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
                                                                                                                        
 [ERROR] Could not process "test.php" file, due to:                                                                     
         "Syntax error, unexpected T_OBJECT_OPERATOR, Syntax error, unexpected T_OBJECT_OPERATOR". On line: 94          

PHP 8.0+

➜  php81 vendor/bin/rector process test.php --dry-run
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
1 file with changes
===================

1) test.php:3

    ---------- begin diff ----------
@@ @@
 {
     public function run()
     {
-        $localServicesLead?->getContactDetails()?->getEmail();
+        ($nullsafeVariable1 = ($nullsafeVariable2 = $localServicesLead) ? $nullsafeVariable2->getContactDetails() : null) ? $nullsafeVariable1->getEmail() : null;
     }
 }
    ----------- end diff -----------

Applied rules:
 * DowngradeNullsafeToTernaryOperatorRector

I think you need to use php 8.0+ to downgrade it, you can see the example:

https://github.com/rectorphp/rector-src/blob/69872ef5930d31c13bb7c9b1650ff4137269c1a4/.github/workflows/build_scoped_rector.yaml#L38-L42

from rector.

Thank you,

Why should it be restricted to PHP8? the whole point of this lib it that it not runs the code, but travese the AST, no?

from rector.