Comments (3)
ClosureReturnTypeRector
can be added, and register after other closure return types rules so executed on last
from rector.
Looking into this.
At the moment we have single AddArrowFunctionReturnTypeRector
to handle these cases. I think it makes sense, as in the wild there is hundreds of methods/functions, but much less callbacks/arrow functions. So it's easier to review these cases without granulation.
We can introduce possibly single rule, e.g. ClosureReturnTypeRector
to handle such cases. That would keep ClassMethod and Fuction_ rules separated, and easier to add types to closure on separete Rector run :)
from rector.
@samsonasik That's the plan. void
and never
are the easy ones to pick
from rector.
Related Issues (20)
- Return types being overwritten incorrectly HOT 1
- DeadCode rule fail to remove some params HOT 7
- deadCode + codeQuality - Static methods called in `callable` are removed
- Incorrect behavior of AddMethodCallBasedStrictParamTypeRector
- Incorrect behavior of JoinStringConcatRector for multiple \n
- Could not process "C:\xampp72\htdocs\oldboys\atk\ui\smarty\Smarty_Compiler.class.php" file, due to: 1" HOT 2
- Incorrect behavior of AddParamTypeBasedOnPHPUnitDataProviderRector
- Incorrect behavior of SeparateMultiUseImportsRector
- Replace ParameterBagInterface with #[Autowire()] attribute HOT 1
- Incorrect behavior of ExplicitBoolCompareRector - double variable assignment in condition HOT 1
- Incorrect behavior of StrictArrayParamDimFetchRector HOT 1
- How to ignore rules or paths? Documentation outdated! HOT 5
- Incorrect behavior of ParamTypeByMethodCallTypeRector HOT 1
- Incorrect behavior of AddMethodCallBasedStrictParamTypeRector, BoolReturnTypeFromBooleanStrictReturnsRector, ReturnUnionTypeRector HOT 1
- Rector Error Report Post HOT 2
- "System error: "Class League\OAuth2\Client\Grant\RefreshToken was not found while trying to analyse it - red properly." HOT 2
- Incorrect behavior of RemoveNonExistingVarAnnotationRector HOT 4
- Incorrect behavior of NullToStrictStringFuncCallArgRector HOT 5
- Could not to remove positional value from annotation HOT 1
- `UnusedForeachValueToArrayKeysRector` removes values that are used HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rector.