recursionpharma / perp Goto Github PK

Some of the scripts rely on a PY_VERSION being set. To make this more flexible, we should expose this as a user setting and have a few lines to replace the version set in environment-*.yml, Pipfile, and pyproject.toml that updates each of the input files to ensure that the same python version is run across everything. If we do this, then the generate-locks.sh should be called in run-suite.sh, since the lockfiles will need to be generated with the correct version of python. I think pip+venvis using whatever python3 is the default on the docker image. We will want to correct this one as well.

Hello @dmaljovec and @a-y-khan (tagging you since you are in the list of contributors)

The file recursionpharma/perp/requirements/requirements.txt came up as having a lower version of Numpy than the minimum established by NEP29. Our tech radar for Numpy shows that the min version for Python 3.9 should be:

• 1.22.+ by the end of 2023.
• 1.23.+ by June 2024.

To do

• Bump Numpy version in recursionpharma/perp/requirements/requirements.txt, to numpy=1.22+ or numpy=1.23+.

Optional to do

To keep Numpy updated until June 2024, an optional upgrade would be

• Bump Numpy version to numpy=1.25+.

This can wait, though.

Thanks!

Please note that this repository is publicly visible to all users!

/cc @bsukow