redhat-beyond / meetballs Goto Github PK
View Code? Open in Web Editor NEWLicense: MIT License
License: MIT License
in PlayerRating i want to modify the user_id field that is foreign key to the Player Table to be just player.
Because the project uses only static players without the ability to register at the moment, there is a need for a large number of static users of players for regular work.
There are no players users at all in the data migrations
Need to add:
Expected Behavior
A ERD will include Notification entity
Current Behavior
Notification Entity does not exist.
Expected Behavior
Add some design for our web app by the logo's colors
Current Behavior
There is no coherent web design
Acceptance Criteria
Users could see the current weather in the city where the court of the game event is located
There is currently no implementation for it
users will have a template of a login page.
There is currently no template for it
users will be option to click of the button to create a new game event, form already exists.
There is no option to create a new game event from all games.
Edit game-events template, add button, add logic when clicking the button.
Relevant tests for the mechanism after clicking the button and after creating a game event.
Players should have profile page,
Profile page should include games participation history and ratings of player
not implemented
users will have template that contains a specific game event.
no such template exist
Acceptance Criteria
game_event template must be added
routing for template must be added
When adding the pytest framework, we created a couple of dummy test cases. Those should now be removed.
Need to do this change on game_event tests.py for preventing warnings:
from django.utils import timezone
TEST_TIME = timezone.now()
When creating a game event, the number of players required to participate might be grater then the actual number of player in the event, Therefore, it may be problematic with our logic after creating a new event.
We could make the minimum number of players field optional, rather than mandatory.
Application templates should have a base.html template file so they would extends it.
There are no templates at all.
Add a base.html template to the meet_balls_app/templates
We can see the navbar in base.html.
In the navbar there is "Games" button. When you press it, you'll be routed to http://127.0.0.1:8000/game-events
.
Currently, there is no such path available.
@amitCohen2 and I will be working on this new feature.
On game-event page, should be a chat to the specific event.
not implemented
.idea should be in .gitignore
.gitignore dont have line for .idea
just need to add .idea line to .gitignore
Expected Behavior
Current Behavior
Acceptance Criteria
After creating a game event, the player who created the event will be automatically added to it.
Removed User ID of ball responsible field from Game Event table, added ball responsible field to Game Event Player.
Expected Behavior
A user will be able to register to the app.
Current Behavior
no registration page.
removing the class BallGame from game_event models, because it is already in Player class.
Say we have a GameEvent that is supposed to happen in a few days, with 30 players want to participate.
The court size was 30 so everything works well.
But now, for some reason, the court size is getting smaller, for example to 20.
What should happen? Should we not allow decreasing the court size? Should we keep everything the same?
The issue is related to Court PR, and will be discussed in our next meeting.
To improve readability, there’s a need to divide this test into three functions:
In this way every function will be smaller, easier to read and understand.
A file that makes GitHub automatically request a review on a PR that changes the code in the repo.
Time of an event can't be before the time it was created.
In addition, the expected time of a game event most be a least 4 hours or more after for the time it was created.
Need to add:
flake8 is failing as the existing python files do not conform with flake8.
See this dummy PR for details: https://github.com/redhat-beyond/MeetBalls/pull/11/checks
users will have template that contains form fields to create game events
no such template exist
reduce the creation of entities in test files. It would make the code more readable.
court fixture in every test file, same court creation
one court fixture in conftest
some adjustments in relevant test files.
Expected Behavior
A user will be able to see notifications about own events
Current Behavior
no notifications page.
modify the player_id field name to be player and game_event_id name to be game_event
In "test_create_three_courts_without_id":
I'll get to it ASAP.
modify field court_id to be court
reduce the creation of entities in test files. It would make the code more readable.
game event player fixture in every test file, same game event player creation
one game event player fixture in conftest
some adjustments in relevant test files.
As a reviewer in this repo, I have noticed a struggle to write clear and concise pull request descriptions. This can make it difficult for reviewers to understand the purpose and scope of the proposed changes.
To help address this issue, I recommend adding a pull request template.
A template would provide a structured format for writing descriptions, which can improve clarity and consistency.
The template could include sections for:
Templates help you better understand what information you should include in your description and help reviewers evaluate your proposed changes.
This improves the overall quality of submissions and makes the review process more efficient and effective.
Please let me know what you think.
The test test_delete_player_deletes_player_ratings
at player_rating/tests.py
should pass also when we have a real data in out DB.
If we have a real users/players in our DB the test fails because it uses hard coded numbers. It didn't take into consideration other users exist other than the fixture.
reduce the creation of entities in test files. It would make the code more readable.
game event fixture in every test file, same game event creation
one game event fixture in conftest
some adjustments in relevant test files.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.