The blackboardtestcreation from redjocker

stage1 description

I will accept this pull request, but I would like some modifications on gifs.
Your gifs are looking nicer, but I was purposefully not using the keyboard to make inputs because I think it is clearer to see what is happening and because there can be slight changes on how the program behaves typing compared to clicking, specially concerning enter key and next button.
Also you should not have to click to hide the virtual keyboard, it should hide by itself when pressing next button on the last input field, so don't use the hide virtual keyboard button.

Originally posted by @RedJocker in #2 (comment)

stage2 test12 - error message

@OrifjonOlimjonov on your last pull request there was a commit saying

test12 has been fixed

in which you added this code

BlackboardTestCreation/Blackboard/stage2/src/main/java/org/hyperskill/blackboard/ui/login/LoginFragment.kt

Lines 58 to 59 in 4a5b0c6

 if(BaseClient.baseurl.substring(0,15) != "http://10.0.2.2") titleBinding.blackboardTitle.error = 

 "invalid: nodename nor servname provided, or not known"

Can you elaborate on why of that change? On machines I tested that message was the one that was given by the exception that was thrown and the message was being set by these code

BlackboardTestCreation/Blackboard/stage2/src/main/java/org/hyperskill/blackboard/ui/login/LoginViewModel.kt

Lines 87 to 97 in 4a5b0c6

 @Suppress("UNUSED_PARAMETER") 

 private fun onLoginFailure(call: Call, e: IOException) { 

 println("onFailure") 

 val traceToString = e.stackTraceToString() 

 println(traceToString) 

 handler.post { 

 _messageNetworkError.value = e.message 

 _messageLoginError.value = null 

 } 

 }

BlackboardTestCreation/Blackboard/stage2/src/main/java/org/hyperskill/blackboard/ui/login/LoginFragment.kt

Lines 80 to 87 in 4a5b0c6

 loginViewModel.messageNetworkError.observe(viewLifecycleOwner) { errorMessage -> 

 println("messageNetworkError.observe: $errorMessage") 

 if (errorMessage != null) { 

 onNetworkError(errorMessage) 

 } else { 

 titleBinding.blackboardTitle.error = null 

 } 

 }

BlackboardTestCreation/Blackboard/stage2/src/main/java/org/hyperskill/blackboard/ui/login/LoginFragment.kt

Lines 94 to 98 in 4a5b0c6

 private fun onNetworkError(errorMessage: String) { 

 println("LoginFragment.onNetworkError $errorMessage") 

 titleBinding.blackboardTitle.error = errorMessage 

 titleBinding.blackboardTitle.requestFocus() 

 }

Were you having issues without adding that line of code?

Cogniterra

Is there the Cogniterra editing link?

redjocker / blackboardtestcreation Goto Github PK

blackboardtestcreation's People

Contributors

Watchers

Forkers

blackboardtestcreation's Issues

Mockoon

stage1 description

stage2 test12 - error message

stage 2

Cogniterra

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	if(BaseClient.baseurl.substring(0,15) != "http://10.0.2.2") titleBinding.blackboardTitle.error =
	"invalid: nodename nor servname provided, or not known"

	@Suppress("UNUSED_PARAMETER")
	private fun onLoginFailure(call: Call, e: IOException) {
	println("onFailure")
	val traceToString = e.stackTraceToString()
	println(traceToString)

	handler.post {
	_messageNetworkError.value = e.message
	_messageLoginError.value = null
	}
	}

	loginViewModel.messageNetworkError.observe(viewLifecycleOwner) { errorMessage ->
	println("messageNetworkError.observe: $errorMessage")
	if (errorMessage != null) {
	onNetworkError(errorMessage)
	} else {
	titleBinding.blackboardTitle.error = null
	}
	}

	private fun onNetworkError(errorMessage: String) {
	println("LoginFragment.onNetworkError $errorMessage")
	titleBinding.blackboardTitle.error = errorMessage
	titleBinding.blackboardTitle.requestFocus()
	}