redmaner / go-nimiq-rpc Goto Github PK

I was testing out this library in a production setting (upcoming Albatross visualizer) and I noticed the service was using 40 GB of memory an hour in :^)
Closing the http.Response.Bodys with defer fixed it.

Needs defer httpResp.Body.Close() (with error handling) on line 120

Also, this check is wrong.
godoc:

// The http Client and Transport guarantee that Body is always
// non-nil, even on responses without a body or responses with
// a zero-length body. It is the caller's responsibility to
// close Body.

Have you looked at the library https://github.com/ybbus/jsonrpc yet?

It has a few nice features:

• Support for batch requests (doing multiple calls in one round-trip)
• Flexibility: Options for custom HTTP transports and headers
• Unit tests

While the example has a lot of features, there is already a powerful RPC client at https://github.com/nimiq/core-js/blob/master/doc/json-rpc-client.md

I suggest we keep a minimal example in godoc and remove example/ to keep the library more manageable.

Thanks a lot for creating a Go client for the Nimiq RPC interface. This will be helpful in the future!
I will be creating a few issues + PRs with suggestions with minor things I noticed.

Floating point numbers are prone to rounding errors (try python3 -c "print(0.1 + 0.2)" in your terminal). We make an effort to store currency amounts as integers where possible.

The types at

and

should be changed to int64s.