redux-saga / redux-saga-devtools Goto Github PK

@yelouafi you made very helpful devtool for debugging. But after 50 and more iterations of watch / fork / cancel effects the project will work slower and slower. When turning off DockableSagaView, it's all OK.

I think it depend on quantity of effects, and how they are all rendered in Dock panel. But with hidden panel (if I will click Toogle), the same performance.

I've recorded cancellable-counter w/ and w/o DockableSagaView from your example. Notice how the button switches from Cancel increment (1) to increment after 5s.

With DockableSagaView

Without DockableSagaView

Hi @Andarist
I made a few changes, how can I publish the updated package? Should we add CI to make this easier?

Currently shared refs (impl. for channels atm) are stored in the global Redux store. Since there can be multiple instances of the effect view (eg one top level, another in the reactions view). We need a state per instance approach (ie local React state)

AsEffects helpers are not compatible with the new version of redux saga, need to update effects.js to handle both versions

Hi there,

I tried this morning to follow the advice given in this issue (redux-saga/redux-saga#1039) in order to monitor my saga. Unfortunately I was unable to proceed because of two problems:

• This issue (#13) prevented me from using the DockableSagaView component
• I have a race effect in my saga and his presence caused an exception on this line (https://github.com/redux-saga/redux-saga-devtools/blob/master/src/store/reducers.js#L70). The exception was "Cannot read property 'push' of undefined", I will put the stacktrace below but the packager makes it difficult to use.

uncaught at rootSaga 
 at rootSaga 
 at rootSaga 
 TypeError: Cannot read property 'push' of undefined
    at effectsById (http://192.168.1.100.xip.io:8081/index.ios.bundle?platform=ios&dev=true&minify=false:117487:25)
    at combination (http://192.168.1.100.xip.io:8081/index.ios.bundle?platform=ios&dev=true&minify=false:60471:29)
    at dispatch (http://192.168.1.100.xip.io:8081/index.ios.bundle?platform=ios&dev=true&minify=false:60107:22)
    at Object.effectTriggered (http://192.168.1.100.xip.io:8081/index.ios.bundle?platform=ios&dev=true&minify=false:117320:5)
    at runEffect (http://192.168.1.100.xip.io:8081/index.ios.bundle?platform=ios&dev=true&minify=false:61776:32)
    at http://192.168.1.100.xip.io:8081/index.ios.bundle?platform=ios&dev=true&minify=false:62047:7
    at Array.forEach (native)
    at runRaceEffect (http://192.168.1.100.xip.io:8081/index.ios.bundle?platform=ios&dev=true&minify=false:62043:10)
    at runEffect (http://192.168.1.100.xip.io:8081/index.ios.bundle?platform=ios&dev=true&minify=false:61812:549)
    at next (http://192.168.1.100.xip.io:8081/index.ios.bundle?platform=ios&dev=true&minify=false:61727:9)

I am using React Native 0.45.1, redux-saga 0.15.4, redux 3.7.1 and redux-saga-devtools 0.1.1

Thanks again for your work :)

Not sure for the solution of this one. I need just to test the behavior. Never used jest's snapshot testing before (besides it doesn't work on my win10 machine)

Hey.. I might be missing something really simple here, but is there a way to set the toggle to be closed by default? Currently have to close it each time..

Thanks!

Releasing the non UI separately would benefit to to other redux devtools. the monitor's selectors could present normalized data into multiple forms (effects by parent/child relation, by action/reaction, task fork/join relation, channels inter-communication etc)

We need this to release monitor's components in a npm package and make the them themables

I tried running npm run shopping-cart, but did not see any tools pop up in the example. I also saw propTypes errors for the hasChildren and collapsed properties.

Is this project still alive?

Really great bundle. Love seeing how it is coming together.

So... I installed redux-saga-devtools as a dev dependency, but I was still on [email protected].

I spent the last hour trying to figure out why redux saga wasn't responding to effects, before realizing that I didn't have the correct version of redux-saga.

If you add redux-saga as a peer dependency, then npm will warn the user if the user doesn't have the right version, but it will be up to the user to install.

Thanks!

• John

new React gives warnings for proptype importation from React. should be using prop-types package instead

hi team,

when running both examples I'm getting prop-types errors.

Please see below:

Warning: Failed prop type: DockedSagaMonitorView: prop type darkTheme is invalid; it must be a function, usually from the prop-types package, but received undefined.
in DockedSagaMonitorView (created by DockableSagaView)
in DockableSagaView
in div

checkPropTypes.js:19 Warning: Failed prop type: SagaMonitorView: prop type darkTheme is invalid; it must be a function, usually from the prop-types package, but received undefined.
in SagaMonitorView (created by Connect(SagaMonitorView))

Warning: Failed prop type: The prop collapsed is marked as required in EffectEntry, but its value is undefined.
in EffectEntry (created by Connect(EffectEntry))
in Connect(EffectEntry) (created by EffectList)

can you help please?

Should make the reducers easier to read by removing all of the spread props

Error 1: Unhandled JS Exception: Expected a component class, got [object Object].
Error 2: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

I've just started using this devtool and I've noticed it uses 'unkown' in places where I believe you want 'unknown'.