reduxjs / d3-state-visualizer Goto Github PK

@kachkaev what do you think of merging this package and redux-devtools-chart-monitor to monorepo as discussed in reduxjs/redux-devtools#412 and romseguy/d3tooltip/issues/1? I already merged d3tooltip and map2tree. Also created related issues there. If you want to maintain it as a separate repository, that's ok.

@romseguy granted me npm access, so we can use the same packages. The problem is that we wouldn't want to keep orphaned/archived repositories in the org, so after merging to the monorepo we should probably transfer these two repositories back to @romseguy. Sorry that I wasn't active when the discussion about moving to the org started.

I'm hooking into the TreeChart's onClickText prop and using JSONTree to render my object to the right....(using your ChartMonitor in a seperate window).

Might be interesting to incorporate something like this as it sort of becomes a standalone dev tool (I've been using this on it's own all day and not even rendering the normal LogMonitor). Though hooking into the LogMonitor would probably be even cooler : )

Anyhow, thanks for this!

I originally discovered this problem in reduxjs/redux-devtools-chart-monitor#16, but also could reproduce it outside redux-devtools-chart-monitor (see #9).

Looks like the source of the problem in src/charts/tree/tree.js. I'd specifically blame this.__oldData__.

It would be really nice if this could be upgraded. I spent a while trying to do this myself, but ran into limitations with the map2tree library, which may also need to be upgraded.

One of my projects' state model contains a node tree of variable depth, representing a complex query. I have been trying to expand it in the visualizer, but to no avail. It simply shows children[i] nodes after 3 levels in.

I also don't think I can define a tree structure, because of its recursive definition.
Is there currently a way to achieve this without making other parts of the state expand, or this has to be implemented?

Hey guys!

Looks like there is an issue with how d3 reuses nodes. Here is what's happening when I add three leafs to a list at the very top one by one and then remove them (also one by one):

The second (the largest) state branch is not affected at all, but there's quite a lot going on visually.

Those strange unexpected horisontal jumps probably happen because of how d3 treats ids of the nodes. If they are represented as an array and id = i, adding or removing an item in the middle of it is likely to bring in this effect.

To reproduce:

• Dispatch an action that results in some state like book.title where title has a value of cars & trucks
• Open the Redux devtool
• Go to the chart view
• Navigate the state chart from book to title
• Hover over title so you can see its value

The tooltip incorrectly renders HTML contained within the state value. For example, you'd see something like cars & trucks when you should see cars & trucks.

If you click on title to see the table view then the HTML is rendered as expected.

Moved from zalmoxisus/redux-devtools-extension#462

Is there any default option in the code to switch this to vertical view?

Instead of using someArrayChild0 for the first element of someArray, it might be better to use someArray[0]. This is more intuitive and readable in a data visualization.