Comments (4)
ReedCopsey
commented on July 2, 2024
So, there are two things here -
First, I think the evaluation every time you fetch the value after a mapping can be cleaned up a bit. I'll try to update that.
However, setting x.Value will not (by design) cause a processing until the first time the value is read, unless there is an active subscription that uses the signal.
I'm going to try to make a change that will give it the following behavior:
open Gjallarhorn
let x = Mutable.create 0
let f i = printf "processing"; i*i
let y = Signal.map f x // "processing"
printfn "x = %A" x.Value // nothing
printfn "y = %A" y.Value // nothing
printfn "y = %A" y.Value // nothing
x.Value <- 1 // nothing - by design
printfn "y = %A" y.Value // "processing" - gets value at first access, since there's no active subscription
printfn "y = %A" y.Value // nothingNote that having a subscription active would change the behavior -
open Gjallarhorn
let x = Mutable.create 0
let f i = printf "processing"; i*i
let y = Signal.map f x // "processing"
use disp = Signal.Subscription.create ignore y // Add an active subscription - no-op in this case
printfn "x = %A" x.Value // nothing
printfn "y = %A" y.Value // nothing
printfn "y = %A" y.Value // nothing
x.Value <- 1 // "processing" - Subscription needs to update immediately
printfn "y = %A" y.Value // nothing
printfn "y = %A" y.Value // nothingThis is "by design" because I want to allow Signal "data flow" to be setup safely without causing tons of evaluations. The evaluation is only needed when you actually try to read the value unless a subscription is in place (effectively triggering a side effect outside of the "system").
Let me know if this seems acceptable, and I'll try to push out a version with this change ASAP.
from gjallarhorn.
charlesroddie
commented on July 2, 2024
Great. Thanks for the explanations and help with this.
from gjallarhorn.
FoggyFinder
commented on July 2, 2024
@ReedCopsey Not sure I understand why in this line:
x.Value <- 1
printfn "y = %A" y.Value // "processingprocessing" (unexpected)such result.
This is due to the fact that when you declare y do not really have the "first call". And after set in x a new value y, updated...But since it is performed only after the first request, in the result we again get two calls?
from gjallarhorn.
ReedCopsey
commented on July 2, 2024
@charlesroddie and @FoggyFinder I think I have this working now - I have two new tests (to guarantee this doesn't "slip" in the future):
[<Test>]
let ``Issue #16 - Signal.map evaluations - Without Subscription`` () =
use sw = new System.IO.StringWriter()
let x = Mutable.create 0
let f i =
sw.Write("*")
printfn "processing"
i*i
Assert.AreEqual("", sw.ToString())
let y = Signal.map f x // "processing"
Assert.AreEqual("*", sw.ToString())
printfn "x = %A" x.Value // nothing
printfn "y = %A" y.Value // nothing
printfn "y = %A" y.Value // nothing
printfn "Setting value"
x.Value <- 1 // nothing - by design
Assert.AreEqual("*", sw.ToString())
printfn "Before processing"
printfn "y = %A" y.Value // "processing" - gets value at first access, since there's no active subscription
Assert.AreEqual("**", sw.ToString())
printfn "y = %A" y.Value // nothing
Assert.AreEqual("**", sw.ToString())
[<Test>]
let ``Issue #16 - Signal.map evaluations - With Subscription`` () =
use sw = new System.IO.StringWriter()
let x = Mutable.create 0
let f i =
sw.Write("*")
printfn "processing"
i*i
Assert.AreEqual("", sw.ToString())
let y = Signal.map f x // "processing"
Assert.AreEqual("*", sw.ToString())
use disp = Signal.Subscription.create ignore y // Add an active subscription - no-op in this case
printfn "x = %A" x.Value // nothing
printfn "y = %A" y.Value // nothing
printfn "y = %A" y.Value // nothing
Assert.AreEqual("*", sw.ToString())
printfn "Setting value"
x.Value <- 1 // "processing" - Subscription needs to update immediately
Assert.AreEqual("**", sw.ToString())
printfn "After processing"
printfn "y = %A" y.Value // nothing
printfn "y = %A" y.Value // nothing
Assert.AreEqual("**", sw.ToString())Both of these are now passing. As I mentioned, this is effectively exhibiting the behavior I thought would be possible here at the beginning. This still maintains "laziness" but also prevents extra evaluations from occurring, so it should be the best of both scenarios.
Note that some operations (such as Signal.cache and Signal.merge) are not lazy - they really need to evaluate immediately, so they always update and evaluate fully.
from gjallarhorn.
Related Issues (20)
- Problem with loading resources in Wpf.Framework HOT 1
- Validation issue in Binding.mutateToFromViewValidated HOT 4
- Request for Feedback: Update HOT 5
- Elm module HOT 12
- Possible crash issue in BoundCollection
- Add a .Net "standard" version. HOT 16
- Add documentation for Binding API HOT 1
- Add a sample walkthrough which documents how to bind signals in a simple app using this lib HOT 2
- Question: 'Back propogation' from values HOT 5
- Subscriptions fire when mutable is set to same value HOT 5
- What is blocking creating signals from the standard mutables HOT 4
- Unexpected subscription notifications
- Multi targeting
- Errors in CoreTypes.fs HOT 1
- Migration to the FAKE 5
- Validators.containedWithin<RecordType> -> System.FormatException HOT 1
- .Add notifies even when underlying value has not changed HOT 2
- How to build the project? HOT 1
- Errors resulting from 'as self' HOT 5
- `lift` has an unused input
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gjallarhorn.