Comments (2)
@dcortie thanks for finding + reporting the issue. Can you make a pull request for this?
- Fork refnx to your own account.
- Clone your refnx repository to your local computer
- Add the refnx/refnx repository as a remote: `git remote add refnx https://github.com/refnx/refnx.git
- Fetch any changes:
git fetch refnx
- Make sure you're on the master branch:
git checkout master
- Include all recent changes:
git rebase refnx/master
- Make a feature branch: `git checkout -B myfirstPR
- Commit the changes:
git commit -a -m'MAINT: fixed the bug in #618'
- Push the feature branch to your fork: `git push origin myfirstPR
- Go to the refnx/refnx repo and make a PR against the myfirstPR branch on your fork.
@ohcpaull, do you have feedback on this?
from refnx.
Hi @andyfaff , yep @dcortie is completely right. I don't have any feedback other than being annoyed that I made such a silly mistake in the first place...
from refnx.
Related Issues (20)
- fix corner plot resolution after fit in gui
- pip install refnx leads to error with missing "_open_mp_helpers" HOT 3
- Drag and drop datasets doesn't work on windows HOT 1
- Save/reload doesn't work for mixed area models HOT 1
- curvefitter.fit does not accept kwargs for ‘L-BFGS-B’ HOT 2
- progress bar for fitting? HOT 6
- Saving and loading models from code HOT 4
- pyopencl does not play well with multiprocessing.
- Spawning of multiple windows when fitting with refnx HOT 1
- Using specified peak_pos (position, FWHM) in ReductionOptions is applied to both reflected and direct beam HOT 2
- Suggestion: add the option to ignore zeros in ReflectDataset? HOT 9
- Can't use non-Slab object as fronting or backing HOT 5
- Frequent Collapse HOT 5
- Inability to reduce older PNR data as the spin channels were not automatically identified HOT 4
- R increase at the beginning of the curve HOT 7
- Link equivalent parameters doesn't work for a MixedArea model
- refnx doesn't accept pathlib.Path objects as filenames HOT 2
- search not working on readthedocs HOT 2
- Jax backend HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from refnx.