Cannot screenshot multiple stories with addDecorator about storycap HOT 17 CLOSED

@tsuyoshiwada okay 😀 I will try to fix it

from storycap.

1.1.0-alpha.1 – a lot of screenshots are duplicated. I could see button for button story, checkbox, and even App story. It does not got updated.
Using withScreenshot as a global decorator.

from storycap.

This change to the example breaks down creating screenshots.

0a86bce

from storycap.

Hi @tsuyoshiwada, @camsloanftc. I've made the PR, that is fixing a lot of the race conditions in the capturing process. I'm using my fork in the project, that has 120+ stories (syftapp.com). All these stories are capturing by this plugin and are uploading to Argos Ci for the visual regression testing.
I would be appreciated for the review. 😄

from storycap.

Have the same issue

from storycap.

Hi @camsloanftc Thank you for issues! and sorry late...

Is it possible to tell me which version the problem will occur?
Also, if you encounter any errors when using the --debug option, it will be helpful if you let me know together 🙏

from storycap.

I've debugged what in my case, withScreenshot for the story Button.withText is called twice. Therefore counter is more than the results.lengts.
Can't understand why

from storycap.

Hi @alexeybondarenko Thank you for report!
It's a big help 👍

from storycap.

@alexeybondarenko I could confirm that with text was called twice in the same way. I would like to take a closer look.

from storycap.

@camsloanftc @alexeybondarenko
Released as 0.6.1. Please check when you have time.

from storycap.

@tsuyoshiwada thanks 👍 In 0.6.1 the bug with the freezing was fixed.

But I've found the new one. It's related to #3.
I've added the global decorator and in the result, not all stories were screenshotted.

alexeybondarenko@5160eff

Didn't were created the screenshots for:
Tag.with text
Tag.with large size
Heading.with subtitle

UPD:
We also expect the next screenshots
Heading.with title viewport 400 250
Tag.with large size viewport 300 120 x2

Looks like the error on some counter. Because now the number of the screenshot is bigger than 10, but we still have total count 10 in the Capturing screenshot progress bar.

from storycap.

This could help to debug
alexeybondarenko@3617b2c

Contexts for the missed stories was handled after the promise resolution.

Log: debug.log

from storycap.

Hi @alexeybondarenko Thank you for confirmation 😃

There seems to be a case that screenshots are not taken when using the global decorator as you say.
It may take some time to fix the bug. It will be very helpful if you can PR if possible 👍

from storycap.

Hi @alexeybondarenko @camsloanftc I merged #14 PR. Released it as v0.8.0 🎉
Please check when you have time :)

from storycap.

@tsuyoshiwada 👍 it works. I think we can close it.

from storycap.

@alexeybondarenko Thanks 😃 ! Close this Issue.

from storycap.

Can confirm this works in 0.8.0 as well. Thanks!

from storycap.