regimantas / oversampling Goto Github PK

I'm getting a warning when using this library:

C:\Users...\Documents\Arduino\libraries\Oversampling\src\Oversampling.cpp: In member function 'int Oversampling::read(int)':
C:\Users...\Documents\Arduino\libraries\Oversampling\src\Oversampling.cpp:55:23: warning: overflow in implicit constant conversion [-Woverflow]
OversampleCount = 65536;

Being declared as int, OversampleCount cannot be 65536, but rather 65535. I'd suggest to reduce all the SampleCount specific OverSampleCounts by one and to adjust the range of the for loop instead within the Oversampling.ccp file:

for (int i=0; i<=OversampleCount; i++){
      TotalADC = TotalADC + analogRead(pin);
    }

Hi!
in the oversampling section

// Can Lead To Overflow
unsigned long TotalADC = 0;
for (int i=0; i<_Averaging; i++){
for (**long** i=0; i<OversampleCount; i++){
TotalADC = TotalADC + (unsigned long)analogRead(pin);
}
}
TotalADC = (TotalADC >> DecimationCount) / _Averaging; //_Averaging
return TotalADC;

i have changed the internal loop variable counting up to "OversamplingCount" to "long" because of overflow when DecimationCount = 8. In this case OversamplingCount =65536 that equals to zero for an Arduino "int" variable.

Nice job! regards!