rekola / radix-cpp Goto Github PK

Normally next direction is forward, but if current Node is final but also has children, the next direction. This may not be possible, since if new node is added, the direction can change.

Add it to combined field

It assumes size_t is 64 bit

It should be a part of the prefix key since strings, for example, already know their depth

For 64bit: xxHash64, City64, Farm64 or SpookyV2-64
For 32bit: xxHash32, City32, Farm32

As in Swiss Tables

They should be compared as bits, not as floating point types, since floating point comparison is not literal (e.g. 0.0 == -0.0)

This way we can simplify collision handling to only increment the node pointer, check for sentinel, and loop if necessary

A. Ignore broken branches and just go to forward
B. Check if the branches are needed and mark them deleted if not

Either leave tomb stones or move other nodes

Fix the iterator

Different possibilities:

1. Flip the top bit of each 8-bit digit.
2. Add extra sign symbol to the tree

Or total value count

It should also be done before evaluation.

What if the original key gets erased?

This way all the work can be moved to create_nodes_for_key() from emplace() or insert_or_assign().

Ordinal, prefix and key should be all readable from Node.

A. ordinal and prefix in Node: key read as append(prefix, ordinal)
B. ordinal and key in Node: prefix read as prefix(key)
C. prefix and key in Node: ordinal read as top(key)
D. prefix, key and ordinal in node

It can be deduced from the presence of valkey

The pointer could point to either Node or value_type (since iterators can only temporarily point to non-final nodes). If the pointer points to Node, at least offset can be left out. If the pointer points to value_type, everything can be left out, since they can be recostructed from value_type.