renanivo / lambda-s3-sftp Goto Github PK

key_filename does not appear to be used in the script. Should that be removed?

Also, have you given consideration to the security risk in pasting a SSH private key inside the script?

I need to know how to set up the trigger for this scenario. When running, it said no module name Paramiko

Error is:

cp -r /lib/python2.7/site-packages/. dist/
cp: cannot stat '/lib/python2.7/site-packages/.': No such file or directory

Here's the Python paths that exist on Ubuntu 17.10:

 $  python -c "import sys; print('\n'.join(sys.path))"

/usr/lib/python2.7
/usr/lib/python2.7/plat-x86_64-linux-gnu
/usr/lib/python2.7/lib-tk
/usr/lib/python2.7/lib-old
/usr/lib/python2.7/lib-dynload
/home/mark/.local/lib/python2.7/site-packages
/usr/local/lib/python2.7/dist-packages
/usr/lib/python2.7/dist-packages
/usr/lib/python2.7/dist-packages/gtk-2.0

I'm not sure which directory or directory should be used instead.

Since I didn't run make install as root, it seems most files got installed into:

  /home/mark/.local/lib/python2.7/site-packages

If you are using key/password authentication and don't define 'PRIVATE_KEY', the Lambda function fails, because PRIVATE_KEY is used anyway:

not a valid RSA private key file: SSHException Traceback (most recent call last): File "/var/task/main.py", line 18, in lambda_handler pkey = paramiko.RSAKey.from_private_key(StringIO(PRIVATE_KEY)) 

From reading the code and the related docs it appears this could be fixed by defaulting pkey = None and only setting it to the contents of PRIVATE_KEY if PRIVATE_KEY has a non-zero length.

As the project has no automated tests, I think would be good to start with a simple end-to-end test of a s3:ObjectCreated:Put event that uploads a file to a SFTP.

The docker-lambda can be used to invoke the function locally. The SFTP server could be set up with a docker container as well.