renatoutsch / poly-nvd3 Goto Github PK

It looks like you could get away with extending multiBarChart instead of abstractChart and just swapping out the nvModel...

Check out my fork

If you were going to do it, would you take this approach or would you extends abstractChart.

https://github.com/PolymerElements/marked-element/blob/master/bower.json#L29

In https://github.com/RenatoUtsch/poly-nvd3/blob/master/bower.json#L24 there is a reference in the "dependencies" section to:
"iron-component-page": "PolymerElements/iron-component-page#~1.0.5",
This dependency pulls many other dependcies which are most likely for the nice display of irion-component-page.

poly-nvd3#1.4.1 bower_components\poly-nvd3
├── d3#3.5.16
├── d3-import#1.0.0
├── iron-ajax#1.0.9
├── iron-component-page#1.0.9
├── iron-resizable-behavior#1.0.3
├── nvd3#1.8.2
└── polymer#1.4.0

iron-component-page#1.0.9 bower_components\iron-component-p
├── hydrolysis#1.23.1
├── iron-ajax#1.0.9
├── iron-doc-viewer#1.0.14
├── iron-flex-layout#1.3.1
├── iron-icons#1.1.3
├── iron-selector#1.3.0
├── paper-header-panel#1.1.5
├── paper-styles#1.1.4
├── paper-toolbar#1.1.4
└── polymer#1.4.0

wouldn't it be suffcient to just add it as a "devDependencies" similar to the marked-element which is maintained by the PolymerElements team
https://github.com/PolymerElements/marked-element/blob/master/bower.json#L29

"iron-component-page": "PolymerElements/iron-component-page#^1.0.0",

Such as https://github.com/mbostock/d3/blob/master/LICENSE

Having a BSD clause in the bower.json file alone is a little ambiguous.

I just started playing with your components last night. Let me say, well done.. I applaud your work.

It looks like attributes for height and width must be explicitly provided. I was wondering what your take may be on how to implement a responsively sized chart.

I'm currently binding height/width using an approach that is something like this...

  <nvd3-line-chart height="{{chartHeight}}" width="{{chartWidth}}"></nvd3-line-chart>

domReady: function() {
    this.chartHeight = this.offsetHeight * .8;
    this.chartWidth = this.offsetWidth *.8;
}

I was thinking of using the resizable mixin, recalculating values. I'm also new to nvd3 and am unsure if there is a built-in mechanism that would be more appropriate than my approach.

I did find this example: lineChartSVGResize.html

It looks like nv.utils.windowResize could do the trick if I were able to provide some sort of configuration (simple attribute or callback function) to nvd3-abstract-chart

On Chrome and Firefox works ok. Is there any extra configuration to make it work on safari 9+?