renaudjenny / steamscrum Goto Github PK

It would be more useful to set participants to a Refinement Session instead of the User Story Vote. Because in a Refinement Session, the goal is very often to set Story Points to several User Story, and redefine which participants is voting for each User Story is unnecessary.

The readme is a bit scarce, I think it should include:

• objective of the repository (long term/short term)
• example url (your heroku site)
• tutorial to install or use (this point may be open to merge request)

The readme seems outdated. As I actually use CSS (Milligram). So better to update the README to reflect the truth!

I commented out every references to SQLite as when I deploy on Heroku, it will lead to a crash at the compilation because sqlite driver is not available on their distant machine.

I only use SQLite for testing purpose (that accelerates the tests and avoid touching a "real" database, thanks to the app.databases.use(.sqlite(.memory), as: .sqlite) option which is amazing!).

Could be nice to avoid that, because it will slow us down when we want to test, or deploy and forget to comment out back :(.

Running a script that does the comment job for us could be fine.

When we try to save a vote, it displays a message to the user that's not implemented yet.
We should create a new table and persist votes.

JavaScript code starts to grow too much to be kept in a single file.
Event more, there is multiple checks if a components it's on this page or not, that could be avoided by putting a single script file per page and using ES6 import for a potential "common.js" if it works like expected.

Like we did for Homepage, we could also extract the embedded JavaScript from the Grooming Session template into its own file.

It could be nice to add a QR Code in the top right of the page as it's useful for mobile device to scan the code and be redirected directly to the vote page instead of navigating through Grooming Session ➡️ User Story ➡️ Vote.
An interesting library to get the code from is this one: https://github.com/nayuki/QR-Code-generator
There is a Rust version 😏...

As the application grows, we will experience some wrong behaviour if don't tackle that ASAP.
We should address this issue before adding more stuff to the Store.

As we are using inlined HTML code, which is very ugly. This library here: https://github.com/vapor-community/HTMLKit could help a lot to improve this part of the code.

Grooming Session has wrong connotation nowadays, it should be changed by Refinement Session

The displayed order of Grooming Sessions seems to be no consistent (especially if you remove one item, and add another later).
We could simply order them by date.

Favicon and other meta are missing. Could be nice to add them to improve the user experience.
See https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/The_head_metadata_in_HTML

https://stackoverflow.com/questions/37669391/how-to-get-rid-of-underline-for-link-component-of-react-router

See https://github.com/renaudjenny/SwiftPastTen/blob/main/.github/workflows/swift.yml

See https://github.com/renaudjenny/SwiftClockUI/blob/main/Sources/.swiftlint.yml

As Heroku support for Swift 5.3 is confirmed by #30, we should reflect that in the Package.json and removing the self. when not necessary in the code.

Message from the last Heroku deploy:

This app is using the Heroku-16 stack, which is deprecated:
https://devcenter.heroku.com/changelog-items/1958
From May 1st 2021, Heroku-16 will be end-of-life, and apps using it
will no longer receive security updates, and be run at your own risk.
From June 1st 2021, builds will no longer be allowed for Heroku-16 apps.
Please upgrade to a newer stack as soon as possible:
https://devcenter.heroku.com/articles/upgrading-to-the-latest-stack
https://help.heroku.com/0S5P41DC/heroku-16-end-of-life-faq

We have now something like 4 different templates that repeat the same code for Head. This should be refactored with something smart that we can inject the Script { ... } we want into it.