renproject / darknode-sol Goto Github PK

We have the option of requiring Shift Adapters to take in the payload as bytes or as arbitrary parameters:

function trade(
    uint256 amount, bytes32 nHash, bytes calldata sig,
    // Payload
    uint256 relayerFee, uint256 someOtherValue
) external payable {
    verifySig(sig, abi.encode(relayerFee, someOtherValue));
    ...
}

or

function trade(
    uint256 amount, bytes32 nHash, bytes calldata sig, bytes calldata payload
) external payable {
    [uint256 relayerFee, uint256 someOtherValue] = abi.decode(payload);
    verifySig(sig, payload);
    ...
}

This contract will be known as the Protocol contract and will be used by the Darknodes to retrieve DarknodeRegistry, DarknodePayment, ShifterRegistry, and any other relevant contract addresses.

Tracking

• Protocol contract built
• Tested
• Deployed

Description

The developer docs only show how to include the basic Shifter and ShifterRegistry interfaces. A more comprehensive integration guide should be included.

Checklist

• Publish contract repository to npm at @renproject/contracts.
• Document importing contracts from @renproject/contracts.
• Document setting up local tests using RenJS and ganache-cli.

• Rename Shifter to Gateway
• Rename shiftIn/shiftOut to mint/burn
• Rename shiftOutRef to n
• Rename ShifterRegistry to GatewayRegistry
• Rename ShiftedERC20 to RenERC20
• Add permit function to renERC20s
• Make the renERC20s are upgradable (with upgrading tests)
• Add contract for continuous fees:
  • Public getter, authorised setter, for "rate" variable
  • Start "rate" at 1.0
  • Scale from raw amounts when minting
  • Scale to raw amounts when burning
• Allow for upgradable deregistration time
• Purge all references to "Republic"
• Can look up gateways in GatewayRegistry by "BTC" instead of "renBTC"
• Ensure payment contract can be changed to a completely different contract implementation
• Comments, documentation, and testing

Substantial changes to the Solidity contracts have rendered our testing suite obsolete. We need to address this immediately. Each Solidity contract should have a dedicated test file configured for use with Truffle, that can be executed and verified by our CI.

Description

Attempted to withdrawal REN and ABC from darknode. Metamask wallet displays

ALERT: Transaction Error. Exception thrown in contract code
and contract gives

Contract 0x5d62ccc1086f38286dc152962a4f3e337eec1ec1
Warning! Error encountered during contract execution [Reverted]

https://kovan.etherscan.io/tx/0xfa08296a1fcd764da633b6b8215670126935851d3ecaf60e1581f22f9cf40b88 > example tx id from failed transaction.

Metamask address is 0x423f7a5f5b33a39b6db98f4b57126d35eb7e1b04
darknode eth address is 0x915d3214d40bc8661552Cf0Cc6628816c2727B2C
darknode ip address is 54.201.93.60

Expected Behavior

Click "withdrawal" on darknode and receive funds in metamask wallet

Steps to reproduce

click 'withdrawal"
metamask is unlocked, and asks to confirm transaction.
metamask displays "ALERT: Transaction Error. Exception thrown in contract code "
and once confirmed, tx will pend and then give error.

Version

MetaMask Version
4.9.2

Operating system

Google Chrome Version 68.0.3440.84 (Official Build) (64-bit)
Ubuntu Linux 18.04.1