Giter VIP home page Giter VIP logo

Comments (7)

glennsl avatar glennsl commented on July 1, 2024 1

My guess is it has something to do with #6609. @tsnobip?

from rescript-compiler.

tsnobip avatar tsnobip commented on July 1, 2024 1

My guess is it has something to do with #6609. @tsnobip?

@glennsl It definitely looks like it's related. Could you come up with a minimal repro on the playground? I'll add a test for it in the syntax package and I'll try to solve it next week.

from rescript-compiler.

glennsl avatar glennsl commented on July 1, 2024 1

Yes, this will also trigger it:

<div />
n->f

That should cover all the cases I've found in my own codebase.

from rescript-compiler.

tsnobip avatar tsnobip commented on July 1, 2024 1

@glennsl this should be fixed by #6686, don't hesitate to review the PR if you want.

from rescript-compiler.

glennsl avatar glennsl commented on July 1, 2024

It seems to have been introduced in rc.2, rc.1 compiles fine.

from rescript-compiler.

glennsl avatar glennsl commented on July 1, 2024

Here's a repro:

let msg = "hello"

module C = {
  @react.component
  let make = (~children as render) => render()
}

<C> ...{() => msg->React.string} </C>

https://rescript-lang.org/try?version=v11.1.0-rc.4&code=DYUwLgBAtgzg5hAvBARACxMYB7FAoPKbAEwFdQIBhJCAbzwggAEAnEAQwGMwA6T7KAAdsAOxAiwDCKEhR2AaxA0AFAD9OaAJbBibERHYwIe4iBYBKJAD5j40y2Xm8AXwIAeSjZ7faj69HgAWisAJQ5uHhgwFk0ROGcINwB6TzwgA

from rescript-compiler.

tsnobip avatar tsnobip commented on July 1, 2024

thanks @glennsl, are there other syntax issues that are not related to children spread?

from rescript-compiler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.