retraigo / duration.js Goto Github PK

Describe the bug
Spaces in the the provided string are ignored by fromString() which leads to unexpected behavior.

Steps to Reproduce
Duration.fromString("5 m s")

Expected behavior
Behaves like Duration.fromString("5m")

What happens
Behaves like Duration.fromString("5ms")

Describe the bug

error: Uncaught TypeError: Cannot read properties of undefined (reading 'type')
      if (obj.type === next.type) break;
                            ^
    at Duration.getFormattedDuration (https://deno.land/x/[email protected]/index.js:155:29)

Describe the bug
Regex matches weird stuff. For example, 10 hamburgers is matched the same way as 10 hours.

Expected behavior
10 hamburgers gets ignored.

• Simplify getFormattedDuration.
• Replace getSimpleFormattedDuration with toString.
• Remove getSimpleFormattedDuration.
• Replace getFormattedDuration with format.
• Remove getFormattedDuration.
• Replace stringify with format.
• Remove stringify.