rexut / ausweisapp2 Goto Github PK

This project forked from governikus/ausweisapp

Der Quellcode wird unter der EUPL v1.2 bereitgestellt. Ausnahme: Die Bibliothek OpenSSL, die unter der OpenSSL License / SSLeay License lizensiert ist. Die Datei "LICENSE.officially.txt" gilt ausschließlich für die offizielle Version der AusweisApp2, welche von der Governikus GmbH & Co. KG im Auftrag des Bundes bereitgestellt wird.

Home Page: https://www.ausweisapp.bund.de/

License: Other

CMake 3.78% Python 1.75% HTML 0.13% Shell 0.18% XSLT 0.02% Dockerfile 0.16% Groovy 1.52% AppleScript 0.03% QML 9.10% JavaScript 0.19% C++ 82.57% Java 0.39% Objective-C++ 0.19%

ausweisapp2's People

Contributors

Watchers

ausweisapp2's Issues

Failed test cases

There are some tests that will not run properly without unexpected errors or exceptions.

135/167 Test #135: Test_network_NetworkManager ...............................***Failed 0.21 sec (Click to expand)

136/167 Test #136: Test_network_TlsChecker ...................................***Exception: SegFault 0.40 sec (Click to expand)

144/167 Test #144: Test_remote_device_RemoteConnector ........................***Exception: Other 0.37 sec (Click to expand)

148/167 Test #148: Test_remote_device_RemoteHelper ...........................***Exception: Other 0.42 sec (Click to expand)

153/167 Test #153: Test_remote_device_RemoteTlsServer ........................***Exception: SegFault 0.31 sec (Click to expand)

154/167 Test #154: Test_remote_device_RemoteWebSocketServer ..................***Exception: Other 0.63 sec (Click to expand)

156/167 Test #156: Test_securestorage_SecureStorage ..........................***Failed 0.05 sec (Click to expand)

157/167 Test #157: Test_securestorage_TlsConfiguration .......................***Failed 0.04 sec (Click to expand)

162/167 Test #162: Test_settings_KeyPair .....................................***Exception: Other 0.47 sec (Click to expand)

164/167 Test #164: Test_settings_RemoteServiceSettings .......................***Exception: Other 0.67 sec (Click to expand)

Build artifacts were created inside sources

There are some interim artifacts that will not create inside the build directory. Instead, they are created in the source directory. This indicates a problem in CMake configuration files.

resources/qml_stationary/AusweisApp2/Global/Category.jsc (Click to expand)

resources/qml_stationary/AusweisApp2/Global/Constants.qmlc (Click to expand)

resources/qml_stationary/AusweisApp2/Global/PlatformConstants.qmlc (Click to expand)

resources/qml_stationary/AusweisApp2/Global/Utils.jsc (Click to expand)

test/qml/test_Utils.qmlc (Click to expand)

test/qml_stationary/AusweisApp2/Global/test_Utils.qmlc (Click to expand)

Travis-CI is broken

There is a Python package dependency mismatch in Alpine Linux v3.8, see Alpine bug report 9238. To solve this issue the Travis-CI setup script resources/travis/setup.sh should install py2-requests from edge in version 2.19.1-r0.

Error is: https://travis-ci.org/rexut/AusweisApp2/jobs/415375618

Implicit casts of `QPointer<T>&` in signal/slot connection

There are many compile errors on implicit casts of QPointer<T>& in signal/slot connection when building with GCC < 5.x. The following error happens when building with GCC 4.8.4:

... no matching function for call to ‘QObject::connect(QPointer<T>&, ...)’
... no matching function for call to ‘QObject::disconnect(QPointer<T>&, ...)’

It's apparently a compiler bug that fixed in GCC 5.x and later. However, working around it is not very costly, and GCC 4.8 is supposed to should be supported. Similar report in Qt Bug Database QTBUG-69512.

src/card/base/CardConnectionWorker.cpp (Click to expand)

/tmp/AusweisApp2/src/card/base/CardConnectionWorker.cpp: In constructor ‘governikus::CardConnectionWorker::CardConnectionWorker(governikus::Reader*)’:
/tmp/AusweisApp2/src/card/base/CardConnectionWorker.cpp:21:94: error: no matching function for call to ‘governikus::CardConnectionWorker::connect(QPointer&, void (governikus::Reader::*)(const QString&), governikus::CardConnectionWorker* const, void (governikus::CardConnectionWorker::*)(const QString&))’
  connect(mReader, &Reader::fireCardInserted, this, &CardConnectionWorker::onReaderInfoChanged);
                                                                                              ^
/tmp/AusweisApp2/src/card/base/CardConnectionWorker.cpp:21:94: note:   mismatched types ‘const typename QtPrivate::FunctionPointer::Object*’ and ‘QPointer’
  connect(mReader, &Reader::fireCardInserted, this, &CardConnectionWorker::onReaderInfoChanged);
                                                                                              ^

...

/tmp/AusweisApp2/src/card/base/CardConnectionWorker.cpp:22:93: error: no matching function for call to ‘governikus::CardConnectionWorker::connect(QPointer&, void (governikus::Reader::*)(const QString&), governikus::CardConnectionWorker* const, void (governikus::CardConnectionWorker::*)(const QString&))’
  connect(mReader, &Reader::fireCardRemoved, this, &CardConnectionWorker::onReaderInfoChanged);
                                                                                             ^
/tmp/AusweisApp2/src/card/base/CardConnectionWorker.cpp:22:93: note:   mismatched types ‘const typename QtPrivate::FunctionPointer::Object*’ and ‘QPointer’
  connect(mReader, &Reader::fireCardRemoved, this, &CardConnectionWorker::onReaderInfoChanged);
                                                                                             ^

...

/tmp/AusweisApp2/src/card/base/CardConnectionWorker.cpp:23:105: error: no matching function for call to ‘governikus::CardConnectionWorker::connect(QPointer&, void (governikus::Reader::*)(const QString&), governikus::CardConnectionWorker* const, void (governikus::CardConnectionWorker::*)(const QString&))’
  connect(mReader, &Reader::fireCardRetryCounterChanged, this, &CardConnectionWorker::onReaderInfoChanged);
                                                                                                         ^
/tmp/AusweisApp2/src/card/base/CardConnectionWorker.cpp:23:105: note:   mismatched types ‘const typename QtPrivate::FunctionPointer::Object*’ and ‘QPointer’
  connect(mReader, &Reader::fireCardRetryCounterChanged, this, &CardConnectionWorker::onReaderInfoChanged);
                                                                                                         ^
At global scope:
cc1plus: warning: unrecognized command line option "-Wno-gnu-zero-variadic-macro-arguments" [enabled by default]

src/qml/HistoryModel.cpp (Click to expand)

/tmp/AusweisApp2/src/qml/HistoryModel.cpp: In constructor ‘governikus::HistoryModel::HistoryModel(governikus::HistorySettings*, QObject*)’:
/tmp/AusweisApp2/src/qml/HistoryModel.cpp:122:115: error: no matching function for call to ‘governikus::HistoryModel::connect(QPointer&, void (governikus::HistorySettings::*)(), governikus::HistoryModel* const, void (governikus::HistoryModel::*)())’
  connect(mHistorySettings, &HistorySettings::fireHistoryInfosChanged, this, &HistoryModel::onHistoryEntriesChanged);
                                                                                                                   ^
/tmp/AusweisApp2/src/qml/HistoryModel.cpp:122:115: note:   mismatched types ‘const typename QtPrivate::FunctionPointer::Object*’ and ‘QPointer’
  connect(mHistorySettings, &HistorySettings::fireHistoryInfosChanged, this, &HistoryModel::onHistoryEntriesChanged);
                                                                                                                   ^

...

/tmp/AusweisApp2/src/qml/HistoryModel.cpp:123:105: error: no matching function for call to ‘governikus::HistoryModel::connect(QPointer&, void (governikus::HistorySettings::*)(bool), governikus::HistoryModel* const, void (governikus::HistoryModel::*)(bool))’
  connect(mHistorySettings, &HistorySettings::fireEnabledChanged, this, &HistoryModel::fireEnabledChanged);
                                                                                                         ^
/tmp/AusweisApp2/src/qml/HistoryModel.cpp:123:105: note:   mismatched types ‘const typename QtPrivate::FunctionPointer::Object*’ and ‘QPointer’
  connect(mHistorySettings, &HistorySettings::fireEnabledChanged, this, &HistoryModel::fireEnabledChanged);
                                                                                                         ^

...

/tmp/AusweisApp2/src/qml/HistoryModel.cpp: In member function ‘virtual bool governikus::HistoryModel::removeRows(int, int, const QModelIndex&)’:
/tmp/AusweisApp2/src/qml/HistoryModel.cpp:369:118: error: no matching function for call to ‘governikus::HistoryModel::disconnect(QPointer&, void (governikus::HistorySettings::*)(), governikus::HistoryModel* const, void (governikus::HistoryModel::*)())’
  disconnect(mHistorySettings, &HistorySettings::fireHistoryInfosChanged, this, &HistoryModel::onHistoryEntriesChanged);
                                                                                                                      ^
/tmp/AusweisApp2/src/qml/HistoryModel.cpp:369:118: note:   mismatched types ‘const typename QtPrivate::FunctionPointer::Object*’ and ‘QPointer’
  disconnect(mHistorySettings, &HistorySettings::fireHistoryInfosChanged, this, &HistoryModel::onHistoryEntriesChanged);
                                                                                                                      ^

...

/tmp/AusweisApp2/src/qml/HistoryModel.cpp:371:115: error: no matching function for call to ‘governikus::HistoryModel::connect(QPointer&, void (governikus::HistorySettings::*)(), governikus::HistoryModel* const, void (governikus::HistoryModel::*)())’
  connect(mHistorySettings, &HistorySettings::fireHistoryInfosChanged, this, &HistoryModel::onHistoryEntriesChanged);
                                                                                                                   ^
/tmp/AusweisApp2/src/qml/HistoryModel.cpp:371:115: note:   mismatched types ‘const typename QtPrivate::FunctionPointer::Object*’ and ‘QPointer’
  connect(mHistorySettings, &HistorySettings::fireHistoryInfosChanged, this, &HistoryModel::onHistoryEntriesChanged);
                                                                                                                   ^
At global scope:
cc1plus: warning: unrecognized command line option "-Wno-gnu-zero-variadic-macro-arguments" [enabled by default]

src/widget/DiagnosisGui.cpp (Click to expand)

/tmp/AusweisApp2/src/widget/DiagnosisGui.cpp: In member function ‘void governikus::DiagnosisGui::activate()’:
/tmp/AusweisApp2/src/widget/DiagnosisGui.cpp:50:72: error: no matching function for call to ‘governikus::DiagnosisGui::connect(QPointer&, void (QDialog::*)(int), governikus::DiagnosisGui* const, void (governikus::DiagnosisGui::*)())’
  connect(mDialog, &QDialog::finished, this, &DiagnosisGui::fireFinished);
                                                                        ^
/tmp/AusweisApp2/src/widget/DiagnosisGui.cpp:50:72: note:   mismatched types ‘const typename QtPrivate::FunctionPointer::Object*’ and ‘QPointer’
  connect(mDialog, &QDialog::finished, this, &DiagnosisGui::fireFinished);
                                                                        ^
At global scope:
cc1plus: warning: unrecognized command line option "-Wno-gnu-zero-variadic-macro-arguments" [enabled by default]

src/widget/SetupAssistantGui.cpp (Click to expand)

/tmp/AusweisApp2/src/widget/SetupAssistantGui.cpp: In member function ‘void governikus::SetupAssistantGui::activate()’:
/tmp/AusweisApp2/src/widget/SetupAssistantGui.cpp:39:123: error: no matching function for call to ‘governikus::SetupAssistantGui::connect(QPointer&, void (governikus::SetupAssistantWizard::*)(), governikus::SetupAssistantGui* const, void (governikus::SetupAssistantGui::*)())’
   connect(mWizard, &SetupAssistantWizard::fireChangePinButtonClicked, this, &SetupAssistantGui::fireChangePinButtonClicked);
                                                                                                                           ^
/tmp/AusweisApp2/src/widget/SetupAssistantGui.cpp:39:123: note:   mismatched types ‘const typename QtPrivate::FunctionPointer::Object*’ and ‘QPointer’
   connect(mWizard, &SetupAssistantWizard::fireChangePinButtonClicked, this, &SetupAssistantGui::fireChangePinButtonClicked);
                                                                                                                           ^
At global scope:
cc1plus: warning: unrecognized command line option "-Wno-gnu-zero-variadic-macro-arguments" [enabled by default]

src/widget/step/StepChooseCardGui.cpp (Click to expand)

/tmp/AusweisApp2/src/widget/step/StepChooseCardGui.cpp: In constructor ‘governikus::StepChooseCardGui::StepChooseCardGui(const QSharedPointer&, governikus::AuthenticateStepsWidget*)’:
/tmp/AusweisApp2/src/widget/step/StepChooseCardGui.cpp:42:105: error: no matching function for call to ‘governikus::StepChooseCardGui::connect(QPointer&, void (governikus::ReaderDeviceGui::*)(), governikus::StepChooseCardGui* const, void (governikus::StepChooseCardGui::*)())’
  connect(mReaderDeviceGui, &ReaderDeviceGui::fireFinished, this, &StepChooseCardGui::onSubDialogFinished);
                                                                                                         ^
/tmp/AusweisApp2/src/widget/step/StepChooseCardGui.cpp:42:105: note:   mismatched types ‘const typename QtPrivate::FunctionPointer::Object*’ and ‘QPointer’
  connect(mReaderDeviceGui, &ReaderDeviceGui::fireFinished, this, &StepChooseCardGui::onSubDialogFinished);
                                                                                                         ^
At global scope:
cc1plus: warning: unrecognized command line option "-Wno-gnu-zero-variadic-macro-arguments" [enabled by default]

Local declaration shadows another object member

There are some few compile warnings about local declaration shadows another object member [-Wshadow].

src/widget/AboutDialog.cpp (Click to expand)

/tmp/AusweisApp2/AusweisApp2/src/widget/AboutDialog.cpp: In constructor ‘governikus::AboutDialog::AboutDialog(QWidget*)’:
/tmp/AusweisApp2/src/widget/AboutDialog.cpp:49:14: warning: declaration of ‘size’ shadows a member of 'this' [-Wshadow]
  const QSize size = icon.actualSize(QSize(64, 64));
              ^
At global scope:
cc1plus: warning: unrecognized command line option "-Wno-gnu-zero-variadic-macro-arguments" [enabled by default]

src/widget/AppQtMainWidget.cpp (Click to expand)

/tmp/AusweisApp2/src/widget/AppQtMainWidget.cpp: In member function ‘void governikus::AppQtMainWidget::refreshLanguageButton()’:
/tmp/AusweisApp2/src/widget/AppQtMainWidget.cpp:588:14: warning: declaration of ‘locale’ shadows a member of 'this' [-Wshadow]
  const auto& locale = LanguageLoader::getInstance().getUsedLocale();
              ^
At global scope:
cc1plus: warning: unrecognized command line option "-Wno-gnu-zero-variadic-macro-arguments" [enabled by default]

src/widget/SetupAssistantWizard.cpp (Click to expand)

/tmp/AusweisApp2/src/widget/SetupAssistantWizard.cpp: In member function ‘QString governikus::SetupAssistantWizard::createAccessibleName(const QString&, const QString&) const’:
/tmp/AusweisApp2/src/widget/SetupAssistantWizard.cpp:74:7: warning: declaration of ‘result’ shadows a member of 'this' [-Wshadow]
  auto result = pName + QStringLiteral(". ") + tr("Step %1 of %2").arg(stepIndex, pageCount) + QStringLiteral(". ") + pText;
       ^
At global scope:
cc1plus: warning: unrecognized command line option "-Wno-gnu-zero-variadic-macro-arguments" [enabled by default]

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.