Comments (6)
rgthree
commented on June 28, 2024
The state in your full workflow does look like it should work. Bypassing isn't provided by my nodes here, but looking at the code in comfy, when your "Upscale Image (using Model)" image input works backwards, it looks like it should follow the two Detailer nodes up to the switch. If you've pulled the latest version (after fixing #10), then that Switch should be choosing the Refiner Context with a valid Image.
Can you add a "Preview Image" node after that switch's with the switch's image output, and again after the two Detailers? If Comfy is working as it looks like it should, those two should be the same and from your refiner (looking at your full workflow, with Revision muted)
from rgthree-comfy.
alessandroperilli
commented on June 28, 2024
Well, at least I understood how it works.
I tried to place a debug Preview Image node everywhere but it's useless. The workflow simply doesn't start, so nothing gets processed at all. The only thing that works is the generation of a new seed.
from rgthree-comfy.
rgthree
commented on June 28, 2024
If you’d like, you can share your workflow JSON and I’ll take a look when I have a chance
from rgthree-comfy.
alessandroperilli
commented on June 28, 2024
Much appreciated. The json is here.
from rgthree-comfy.
rgthree
commented on June 28, 2024
Huh, so I found the error, and as I thought it's nothing to do with my nodes (phew!) or even your general workflow.
Looks like the two SEGS Reroute nodes you have going from the 'Size of the Small Faces' node over to the 'Detailer for BigFaces; node are using "Primitive Reroute" nodes from https://github.com/pythongosssss/ComfyUI-Custom-Scripts which, I guess, aren't compatible with ComfyUI's bypassing. The error comes from that node.
If you replace those with normal Reroute (or, my Reroute) nodes it seems to work fine.
(Note that in the pythongosssss README, they do state that their Primitive Reroute node should not be used for normal rerouting. I'm sure it was just a mistake, but just making note).
from rgthree-comfy.
alessandroperilli
commented on June 28, 2024
A valuable lesson. Thank you so much for the time you dedicated to it.
from rgthree-comfy.
Related Issues (20)
- error messages when activating / disabling rgthree HOT 2
- SyntaxWarning HOT 1
- REQEUST: A reroute node with randomizer & scaling input HOT 3
- Bookmark node - sticky keys HOT 7
- [FEATURE REQUEST] Stylizable progressbar (shadow-root) via User.css HOT 1
- Make dependees of muted node not crash, but simply be ignored HOT 1
- Feature Request: Sound notification when generation completes
- Is there an external one-click switch to control the fast group mute? HOT 2
- [BUG] Power Lora Loader Strength value numeric entry popup doesn't work after sliding the value HOT 2
- OverflowError: cannot fit 'int' into an index-sized integer HOT 4
- Feature Request: I want the Strength value range for Power Lora to be in increments of 0.1. HOT 1
- Why does the cache seem to be useless? HOT 3
- context big scheduler array broken after update HOT 2
- How to clear recursion in workflow HOT 1
- [BUG?] Reroute node doesn't connect to KSampler when transporting Sampler and Scheduler values HOT 2
- More inputs for context switches? HOT 1
- Any Switch handling of empty text values HOT 6
- how to set custom dimensions in SDXL Empty Latent Image
- How to refresh the lora info in the Show Info panel?
- Feature suggestion: node output and input remember choice suggestions on dragging to nothing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rgthree-comfy.