rhyswynne / inline-tweet-sharer Goto Github PK

https://www.example.com/story-that-is-being-shared?_inline-tweet-share

Look like this at the moment. May be a small issue.

Just a quick note here: for those who use bit.ly custom short domains, adding the ability to manually specify the domain to be used would be useful. Simply changing the inline-tweet-sharer-urlshortened value to the domain seems to fix it, but from a UI point of view having either the option to manually enter via input in the admin panel or have the API detect all domains associated with the account would be a nice touch.

Could be default twitter button, current button, or just another button added to media library

From - https://wordpress.org/support/topic/suggestion-combine-dialog-boxes-change-text-option

Combine the three dialogue boxes to a single one, with three entry fields. It would make it more user friendly. Avoid unnecessary clicks.

Add API support so the link sent to Twitter is a bit.ly link.

At the moment they are not and it's breaking the "inline" element.

I discovered that the plugin was incorrectly counting and prematurely cutting off tweets due to HTML encoded characters. For example, a quote may be counted as 6 characters (")

In order to alleviate the situation, I updated the count like this:

if ((strlen(utf8_decode($tweetlinkstring))+strlen($permalink)) > 140 ) { $tweetlinkstring = substr( $tweetlinkstring, 0, (140-(strlen(utf8_decode($tweetlinkstring))+strlen($permalink)+3)) ); $tweetlinkstring = preg_replace( '/ [^ ]*$/', '...', $tweetlinkstring ); }

This decodes the tweet string for accurate character count, and also accounts for the length of the link.

From - https://wordpress.org/support/topic/suggestion-combine-dialog-boxes-change-text-option/

Possibility to have a customised text. Explanation: Say I want to highlight a longish sentence, one that is too long for a tweet . Then it would be nice to be able to chose a different text for the tweet that pops up when the reader clicks the text.

Say the highlighted sentence is: "Abraham Lincoln in one of his lucid moments said that well structured and elegant coding is the way to go and the best thing to do". Then it would be good to be able to specify a shorter tweet text, for example: "Abraham Lincoln said you should do elegant and structured code". (Yes, it is a silly example but I hope it illustrates what I mean.)

An option which creates a default prefix & suffix, that can be overwritten (similar to user) would be great - https://wordpress.org/support/topic/automate-the-suffix-and-prefix?replies=1#post-6186210

Please test this content and tweet it.

Цаг агаарын болон бусад хүндрэл учрахгүй бол буудай, төмсний хэрэгцээгээ дотооддоо бүрэн хангах боломжтой болно.

The object the tweet gets wrapped in is currently a div, which I had to set to display: inline, but I also have found that since I use a the simple TinyMCE editor, wordpress puts the div on a new line since the editor automatically puts my text into

tags. So even though my editor looks like this

This is some text [then the shortcode] with what I wanted tweeted [/shortcode] and some text after

The output HTML looks like this

<p>This is some text</p> <div class="inline-tweet"> with what I want tweeted</div> and some text after.

And when that displays, it looks like:

this is some text
with what I wanted tweeted and some text after.

So, I changed in the plugin PHP the div to a span, but I am wondering why it is a div in the first place, since it should always be an inline element inside of a

right? Or could that be an option? I don't want the plugin to break during updates if I manually change the

in WP_DEBUG mode, getting this error on the front end:-

Wrap that into a function and it's sorted :)

Easy fix. Should just have to change it to a "manage_options". Causes issues in WP_DEBUG issue.

Inline Tweet Sharer plugin works perfectly fine. But not on 'paged' posts. When I use the shortcode on paged posts it creates the link for the first page only.

I wish I could describe the situation. You may check it at https://www.dunyahalleri.com/haftanin-ozeti-147/2/