guzzle-psr18-adapter's Introduction

guzzle-psr18-adapter

A (very) simple guzzle PSR-18 adapter.

Requirements

PHP ^7.1 || ^8.0
Guzzle ^6.3

Install

Via Composer

$ composer require ricardofiorani/guzzle-psr18-adapter

Usage

$client = new \RicardoFiorani\GuzzlePsr18Adapter\Client();
$request = new \Your\Implementation\Of\Psr7\Request();
try {
    echo $client->sendRequest($request);
} catch (\Psr\Http\Client\ClientExceptionInterface $exception) {
    // your error handling
}

For futher documentation please see http://docs.guzzlephp.org/en/stable/

Testing

$ composer test

Credits

guzzle-psr18-adapter's People

Contributors

Stargazers

guzzle-psr18-adapter's Issues

Guzzle 7.0

Guzzle 7.0 was release a month ago: https://github.com/guzzle/guzzle/releases/tag/7.0.0

Are there any plans to update this adapter?

GuzzleHttp\Exception\BadResponseException requires a Response object

While I was preparing my package for PSR-18 and used your Guzzle adapter for it, I hit the following error message: Instantiating the GuzzleHttp\Exception\BadResponseException class without a Response is deprecated since version 6.3 and will be removed in 7.0.

The stack trace:

 vendor/guzzlehttp/guzzle/src/Exception/BadResponseException.php:22
 vendor/ricardofiorani/guzzle-psr18-adapter/src/Client.php:42

The fix is fairly easy: Just adding a GuzzleHttp\Psr7\Response instantiation when an exception is raised.

    public function sendRequest(RequestInterface $request): ResponseInterface
    {
        try {
            return $this->send($request);
        } catch (GuzzleException $e) {
            $response = new Response();
            throw new ClientException($e->getMessage(), $request, $response, $e);
        }
    }

Maybe you want to instantiate the Response object outside this client extension, but for now it's a quick win.

Need new Tag for the bugfix

Hi the bug of "provide" a library which is not in the 1.0.3 is a problem for us. Could you please create a new Tag with the fix.

Composer.json lists "psr/http-client" in provide, but does not include it in source code

Doing this prevents this from being installed by other composer.json files that require it as of Composer 2:

composer/composer#9308

PSR-18 is now v1.0

Worth releasing a new version that updates composer.json to use v1.0

Throwing exception on 4xx and 5xx is not compliant with PSR-18

PSR-18 strictly says that on 4xx and 5xx errors client MUST NOT throw an exception so the adapter should unpack response on guzzle BadRequestException s.

https://www.php-fig.org/psr/psr-18/#error-handling

Recommend Projects