richjoslin / rivety Goto Github PK

There are columns in the database named created_on and last_created_on (and in other places, just created).

Something should probably clean this out periodically. It begs the larger question of "Do we want to add some kind of scheduled job thing?"

Discuss.

The script that parses and executes sql statements to migrate databases breaks completely when there is a sql comment in the script, and it doesn't tell anyone about it at all.

The conditional for the delete button is checking just the id instead of entity.id.

There's nothing logging the emailing process, meaning that it's impossible to figure out where it's going wrong.

When you click on any arrow icon in the navigation editor, a database error is thrown to the screen and logged. Best bet is to make it happen while tailing rivety_log to see the exact error.

The CRUDifier should introspect the field type for the database field and guess which kind of form field might be good based on the field type.

Password hashes are not using a salt, meaning that anyone who got the list and a rainbow table would be able to guess a bunch of passwords.

This is probably a result of my theme/pathing re-org the other day.

I took this out as part of resolving issue #18. It should go back in now that the code is sane.

The emailer gets its templates from the theme folder, which it can no longer see because I moved it.

Sometimes in the navigation editor an item will have an up arrow and a down arrow enabled for sorting, even if it's the last item in the list. I've only seen this happen when an item is the last in the list. I'd start by looking at the smarty template code.

This was working at some point in Communitas but has since broken. If you hit a page for which you need to be logged in to see, you should log in and then get redirected to the page you were originally trying to see. Instead, you get redirected to the home page after login.

"A value for the identity was not provided prior to authentication with Zend_Auth_Adapter_DbTable" might be good to know during dev, but it sure isn't much use to the user.

Config admin screen is showing some config settings that look like they have been commented out or something.

Screenshot: http://screencast.com/t/9pZFll68pNPG

Need to be able to take a user to the place they were trying to go after registration, the same way login works.

I would like to see start and end item numbers available

I didn't think it would matter, but now it does. Certain MySQL string functions don't like when a field has one collation and a table has another. Changing them all to the same thing should prevent further issues.

The CRUDifier templates need to be updated with the latest markup, CSS, and coding style.

The navigation is cached by default. Add a button to the navigation editor (or somewhere in the admin) to clear one or all navigation caches.

Saving changes to a navigation scheme will already automatically clear the cache, but modifying the database directly, or running a script, or using a db migration will not clear the cache and it would need to be done manually.

I (and assumedly others) would like a field to store an arbitrary hardware ID which can be passed in from a client device (laptop MAC address, iPhone UDID, etc) and can be used for security purposes. This is more intended to be used with client apps (such as mobile apps) which are using Rivety for REST API endpoints.

Along with the new db field, a new MCA for passing in a hardware ID, and it just updates the current user's hardware ID and does nothing else. The endpoint would only be accessible to users that are logged-in.

My theme files are being used for tpl_common, but for anything in tpl_controllers, it's falling back, even though I've got templates in there. I'm going to add some debug logging statements and try to track down the problem.

currently, the key is numeric and ignored by everything that uses it. I'm going to add the field name so I can do field level error messages.

Because why the hell not?

The include_css and include_js Smarty plugins are using split() but should be using explode() instead.

In the config.ini, we need to add this line:

db.rivety.config.driver_options.1002 = "SET NAMES utf8"

Without this, even with the db, tables, and columns all set to utf8_general_ci collation, all data returned by queries using PDO are converted to ISO-whatever encoding and messing up many of the special characters.

I'm thinking we can override the select/insert/update/delete routines to use a try catch so that DATABASE ERROR doesn't get dumped to the screen instead of either a detailed error message or a friendly 500 error page.

Enable the use of OpenID and other systems for authenticating so users don't have to create new credentials to join the site.

The breadcrumb arrow image has a white background that overlaps when the entry is very short - an alpha there would help.

Even better would be to use CSS to draw that stuff rather than using images - then the colors could be controlled with CSS instead of creating new images.

Password reset does not work correctly. Loads page initially, but doesn't change password and doesn't auto-login.

Remove any Amazon Web Services code from the core and create separate modules for each AWS feature (S3, SQS, CloudFront, etc).

The navigation editor would be a lot easier to use if you could see a list of existing module-controller-actions and then choose which ones you want to "activate" (inserting rows into the default_navigation table). MCAs you've already activated then no longer appear in the list of MCAs to choose from. This can be done based on the "short name" column by being strict about using the m_c_a format in that column.

Currently, the only type is "required". I'd like to add one for "if condition is true" or somesuch.

The url has an extra slash that's throwing off the pager.

Notice: Undefined property: RivetyCore_Request::$locale in /home/developer/websites/ironkingdoms/public/core/default/controllers/NavigationController.php on line 45

To reproduce: edit an item in a role's navigation tree.

Right now I have to copy two full versions of ZF every time I build, which is ~7000 files (no, really).

[copy] Copying 7052 files to /home/jaybill/sites/groupofthings/htdocs

Probably a bit of cutty-pasty code.

We had this whole plan for adding other validators at some point, but it's got some serious flaws. Short of scrapping it, I propose adding a method to the request object that will let you add a validation error yourself, so you don't have to roll your own for validation problems that aren't just required fields.

add arguments to crudify so it grabs its templates from a specified location and dumps the results to a specified location. Omitting the arguments just uses the defaults

Usage: crudify.php [table_name] [optional bool is_admin, default false] [optional templates path] [optional modules folder] [optional views folder]

The star comments don't work right. The hash comments are deprecated.

This is one of those things we did by hand that's now done for us in ZF:

http://framework.zend.com/manual/en/zend.application.introduction.html

We could probably leave this as is basically forever, but if we did break it up this way, we'd be able to use Zend_Test to do unit testing, which I'd really like to be able to do. Certainly not an emergency, but it'd be really neat to have.

Every time someone logs in, update the IP column of the record in the users table.

as titled

So you can add more than one error at a time.

Add a config variable that when set to 0, doesn't load the recursive nav tree.