Giter VIP home page Giter VIP logo

rickgroot / pokemon-game Goto Github PK

View Code? Open in Web Editor NEW

This project forked from cmda-minor-web/real-time-web-2021

0.0 0.0 0.0 32.85 MB

@cmda-minor-web The course Real-Time Web is about learning how to build a real-time application. Real-Time Web is part of the half year minor programme about Web Design and Development in Amsterdam. Bachelor Communication and Multimedia Design, Amsterdam University of Applied Science.

Home Page: https://rick-groot-pokemon-game.herokuapp.com/

License: MIT License

JavaScript 68.67% CSS 21.17% HTML 10.17%

pokemon-game's Introduction

Hi, I'm Rick Groot!

Front-end / SmartTV developer at Triple
A developer with knowledge about design and interaction.

LinkediIn: rick-groot-469777193 GitHub RickGroot

A bit more about me...

const rick = {
    pronouns: "he" | "his",
    code: ["JavaScript", "TypeScript", "HTML", "(S)CSS", "NextJS", "Svelte(kit)"],
    knowledge: ["Development", "Design", "Interaction", "UX"],
    hobbies: ["Playing Trumpet", "Photography", "Lots of gaming"]
}

CSS HTML5 JavaScript Node.js Svelte

pokemon-game's People

pokemon-game's Issues

Peer review - Ben

  • Data model
  • Data-flow diagram
  • Spike test
  • Concept description and API explanation

Feedback:

Data-flow diagram
Data-flow diagram looks good and is clear. A minor thing I would specify more is 'other socket events'. What are these socket events and what do they do?

Data model
Data model looks good and is clear. A minor thing you can do is to make the data model more tailor made for your use case.

Server.js can be modulated more.

I can see quite a few functions that can be modulated in your server.js.
This makes your server.js a lot cleaner and easier to read.

You could add checkRoomCount(), sendUsers(), fetchNewPokemon(), modulateData() and sendPokemon() in a folder named for instance "helpers".

You can do the same for socket.io, just load it in from a seperate file, so that not everything is cluttered on one page.

Timer

While using the application, it might be nice for the users to see how much time they have left to answer

Peer Review

Repo

  • Missing a description and live link in the about section
  • No env. or node modules, git ignore added.
  • Concept, install notes, Data lifecycle diagram and external api added.
  • Real time events section missing

Concept

  • I understand your concept, It's a fun concept and I'm excited to see the finished result.
  • Multi user functionality works as expected

Data life cycle

  • Great data life cycle.
  • Maybe you could name the "other socket events"?

Real-time Events

  • You could refactor some of your app.js so that socket is loaded in from a separate file.

API

  • It's clear what data the api offers.
  • It's clear how to connect to the api, no key is needed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.