Giter VIP home page Giter VIP logo

balloons.io's People

Contributors

andrew avatar bluehaunter avatar cristiandouce avatar egh avatar felipefzdz avatar goshacmd avatar impronunciable avatar jwietelmann avatar lalitkapoor avatar rickyrauch avatar spacecowb0y avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

balloons.io's Issues

Socket Auth Check

Add check to see if users is authenticated before allowing to (listen/emit) and/or connect to socket.

Create init module

Get lines 15 to 41 from balloons.js and create a new "init" file. It can export the redis client.

Authentication Methods

Is there any time frame on other authentication methods? EG: Open/Google Authentication? Regardless im going to look into this myself, im happy to fork this if you would also like to support other methods in future?

"Authentication failed :(" received from "sign in with Twitter" button

Plugged in the keys as instructed. Receive "Authentication failed :(" from the login popup window. Application's environment is as follows:

$ cat /etc/redhat-release 
CentOS release 6.2 (Final)

$ node --version
v0.8.1

$ redis-server --version
Redis server version 2.4.10 (00000000:0)

Consumer Key/Secret is verified to be correct. Help appreciated.

JS Injection

Hi Great work!

But I found an interesting bug I was able to type, <script>alert('JS injection for the win')</script> on the message box and instead of having the chat application post the message as text, it executed the js ... I did some test and the alert box appeared for all chat members.

Can't parse config.json

Running node balloons.js gives me a syntax error in config.json. Any particular reason why this might be?

Fetch room list from db

Now when room list drops down we hold the rooms available from when the user connects to the room. We must show the current available rooms instead.

Server crash after twitter login

Url: domain . com:3000/rooms/list

TypeError: /var/www/chat/views/themes/default/room_list.jade:11
    9|      p
    10|             ul#available_rooms
  > 11|             each room,key in rooms
    12|                 li
    13|                     a(href='/rooms/'+room)= key
    14| 

Cannot read property 'length' of null
    at eval at <anonymous> (/var/www/chat/node_modules/jade/lib/jade.js:160:8)
    at eval at <anonymous> (/var/www/chat/node_modules/jade/lib/jade.js:160:8)
    at Object.<anonymous> (/var/www/chat/node_modules/jade/lib/jade.js:165:12)
    at ServerResponse._render (/var/www/chat/node_modules/express/lib/view.js:422:21)
    at ServerResponse.render (/var/www/chat/node_modules/express/lib/view.js:315:17)
    at /var/www/chat/balloons.js:54:9
    at try_callback (/var/www/chat/node_modules/redis/index.js:484:9)
    at RedisClient.return_reply (/var/www/chat/node_modules/redis/index.js:555:13)
    at HiredisReplyParser.<anonymous> (/var/www/chat/node_modules/redis/index.js:256:14)
    at HiredisReplyParser.emit (events.js:67:17)

Thanks.

Add tests

There are no tests :/

We should use mocha and maybe should.js for assertions

Occassional crash

Hi!

After you posted on HN I couldn't find a demo, so I set one up and have been letting it run all day. You can see it at http://www.pssdbt.com:3000

There were a couple of things I needed to do to get it running, I think I covered them in this comment: http://hackerne.ws/item?id=4061975

It's crashing now every other hour or so (people are in and out from HN) with the following error:

/home/jeff/Balloons.IO/node_modules/easy-oauth/node_modules/connect-auth/lib/auth.strategies/twitter.js:60
                                    this.fail(callback);
                                         ^
TypeError: Object #<Object> has no method 'fail'
    at /home/jeff/Balloons.IO/node_modules/easy-oauth/node_modules/connect-auth/lib/auth.strategies/twitter.js:60:42
    at /home/jeff/Balloons.IO/node_modules/easy-oauth/node_modules/connect-auth/node_modules/oauth/lib/oauth.js:432:22
    at passBackControl (/home/jeff/Balloons.IO/node_modules/easy-oauth/node_modules/connect-auth/node_modules/oauth/lib/oauth.js:366:13)
    at IncomingMessage.<anonymous> (/home/jeff/Balloons.IO/node_modules/easy-oauth/node_modules/connect-auth/node_modules/oauth/lib/oauth.js:378:9)
    at IncomingMessage.emit (events.js:88:20)
    at HTTPParser.parserOnMessageComplete [as onMessageComplete] (http.js:130:23)
    at CleartextStream.socketOnData [as ondata] (http.js:1288:20)
    at CleartextStream._push (tls.js:375:27)
    at SecurePair.cycle (tls.js:734:20)
    at EncryptedStream.write (tls.js:130:13)

Just thought I'd bring it to your attention - otherwise it works pretty well, keep up the good work. Avatars don't work, but that's because it looks like tweetimag.es isn't working.

Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.