ricmoo / pyscrypt Goto Github PK

Hi,

I'd like to use this in a Python 3 project. I notice that your pyaes is Py3 friendly but not this one. AFAICT there are a couple of exception syntax errors (i.e. use except Exception as e: syntax) and old school print statements. I'm guessing bytes / strings in Py3 might also cause issues.

Happy to help if need be.

N.

Modern scrypt API has a maxtime=... parameter instead of N,r,p,dkLen.

I would be nice to have same in this library, so that they are truly interchangeable...

At the first glance, pure-Python seems slow, is the underlying crypto implemented in pure Python, or does it use something from stdlib, etc...

So, for someone who doesn't want to dig too deep, README.md could have a simple performance comparison, e.g. against pypi:scrypt with same settings.

Just an idea for a future enhancement.

Basically on Python 3, the binary file must be opened with the 'rb' mode and I check that the ScryptFile mode matches the file pointer mode.

Since Python 3 makes a distinction between what things like read() return, (bytes for 'rb', strings for 'r') it would be convenient to have the underlying file object opened as 'rb' (which it must be, since the encrypted file is binary) but specify the ScryptFile mode as 'r'. Then read could perform whatever text conversion the built-in file object performs in the case of 'r' vs 'rb'.