Giter VIP home page Giter VIP logo

rigel's Issues

Add updated instructions for setting the colorscheme on slack.

First of all thank you for the beautiful theme. It works perfectly for me.

I followed the instructions to add the colorscheme to slack, and the current steps to do that are a bit different as described in the README.

I am opening this issue to discuss if you think it should be updated or not, and I will also create requests from my fork of the repo.

I look forward for your feedback.

nvim treesitter support

Hi,
first of all: this is my absolute favorite colorscheme. Thanks for making it.

A few months ago I changed my neovim config to use treesitter for highlighting. It's great but it seems to break the colors for Rigel.
I since switched to another scheme but I dearly miss Rigel. Is there a chance that Rigel will be updated to support the treesitter highlight groups? I once tried to update it myself but I failed so far, having little experience with the whole vim color scheme topic.

:set colorcolumn[...] results in illegible text

Text is illegible when colorcolumn is set. This is easily remedied by setting guifg and guibg to NONE and replacing guibg and ctermbg with dark blues like so:

hi ColorColumn guifg=NONE ctermfg=NONE guibg=#002230 ctermbg=230 gui=NONE cterm=NONE

Screenshots:

With :set colorcolumn=100

rigel-colorcolumn-bug

With :set colorcolumn=100 and highlight edits

rigel-colorcolumn-fixed

The dark blue for the colorcolumn might be a bit too subtle, but the basic idea is there. Could possibly make it the same color as the cursorline (guibg=#001a25 ctermbg=234), like so:

image

[Addition] Windows Terminal Theme

Rigel colorscheme could be installed into Windows Terminal by adding following entry into schemes array of settings.json.

I only doubt the choice of selectionBackground color.

{
    "name": "rigel",

    "cursorColor": "#FFCC1B",
    "selectionBackground": "#E6E6DC",
    
    "background": "#002635",
    "foreground": "#E6E6DC",

    "black": "#00384D",
    "blue": "#1C8DB2",    
    "cyan": "#00CCCC",
    "green": "#7FC06E",
    "purple": "#C694FF",
    "red": "#C43061",
    "white": "#77929E",
    "yellow": "#F08E48",
    "brightBlack": "#517F8D",
    "brightBlue": "#7EB2DD",
    "brightCyan": "#00FFFF",
    "brightGreen": "#9CF087",
    "brightPurple": "#FB94FF",
    "brightRed": "#FF5A67",
    "brightWhite": "#B7CFF9",
    "brightYellow": "#FFCC1B"
},

In tmux, color is off

I debugged this issue, and it boiled down to this line:

hi Normal guifg=#e6e6dc ctermfg=254 guibg=#002635 ctermbg=235 gui=NONE cterm=NONE

I'm not familiar enough with the semantics of vim colouring to know why this is happening, but I found something similar on reddit:
https://www.reddit.com/r/neovim/comments/825dj7/the_endless_litany_of_tmux_and_nvim_color_problems/

In here, someone mentions that the line in another colorscheme has this line:

hi Normal ctermfg=252 ctermbg=235 guifg=#c3d5ec guibg=#1e222c

and mentions: "That sets bg=light automatically, Vim helpfully decides that the bg is light, even though bg=dark was explicitly set a few lines above".

For context, here are pictures of vim/neovim run with and without the mentioned line in tmux.

With line:
Screen Shot 2019-09-04 at 5 05 52 PM

Without line:
Screen Shot 2019-09-04 at 5 05 35 PM

By the way, beuatiful colorscheme!

[Suggestion] Submit to 'iTerm2-Color-Schemes' Repository

There's a really great repository with tons of color schemes, not just for iTerm, called iTerm2 Color Schemes. It has tons of color themes, and scripts that can convert iTerm color schemes to other types. It would be really nice to have Rigel be in there, since it's a great theme, and having it in so many other formats would be really nice too.

Issue with terminal color

I think the last commit has caused some issue with my VIM. Every time I run vim I get the following error:

Error detected while processing function <SNR>56_AddAnsiGroups:
line   18:
E254: Cannot allocate color 0
E254: Cannot allocate color 0
Press ENTER or type command to continue

That is a function in coc.nvim. It seems like the g:terminal_ansi_colors has a wrong value that causes this.

:echo g:terminal_ansi_colors
[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]

VS Code Port

I have created a Rigel port for VS Code. It hasn't been submitted to the Visual Studio Marketplace because I want to get your (@Rigellute) feedback to see if there are any other improvements I can make.

If you want to try it out, download my repo and move the folder into your ~/.vscode/extensions directory.

https://github.com/mrmartineau/rigel-vscode

Thanks for the great theme by the way ๐Ÿ‘

Delimiter matching in vim is hard to read

Hi there!

Thanks for the work on this colorscheme!

One thing I've noticed in vim is that, with this colorscheme, the automatic delimiter highlighting gets a little tricky to read. For example, in the following screenshot, my cursor is actually on the last parenthesis of the line: the blue block after empty is just the matching delimiter highlighting.

image

In this example, it's not too bad, but in large codebases where delimiters may be very far up the page, it causes me to lose track of my cursor sometimes.

I looked over the docs, but I couldn't see a mention of this. Have I missed a setting that controls this or do you know if there's a different setting that interferes with coloring? The same screenshot with the Snazzy colorscheme looks like this:

image

In case it matters, my vimrc is here, and the terminal emulator is Konsole.

Add hyper theme

Hi there,

Thank you for inventing the great colour palette. As I know that your repository has already had a hyper theme but it looks incomplete for the following points. Thus, I created an alternative https://github.com/tani/hyper-rigel .

  • hyper-rigel is not uploaded on npmjs.com
  • only available 8 colours.
  • no colour configuration for selection.

If you would not mind merging my repository to your project, and use npmjs.com namespace. Please tell me.
I can send the PR and transfer the package name to your account.

[Addition] Emacs theme

Would love to paint my emacs with rigel theme, as its becoming default theme everywhere.

Workaround
In mean time, I used the existing theme for vim and converted it to rigel-theme.el

Sample
loading the generated theme on vanilla emacs looks like this:
screenshot-20200711-07:21:57

Any emacs folks in house for review ??

[request] support italic

Hi, not sure where to put this feature request so I am adding it here.

Any chance you could support an italic mode ? Say, like gruvebox and onedark ? (they define a global var let g:onedark_terminal_italics = 1 and let g:gruvbox_italic = 1 to allow the style to use italic for comments...)

like this:
image

[Website] order of lightline statusbar example

This is a very minor issue.

The website shows the airline and the lightline statusbar with the applied colors, but the order of the vim modes of the lightline is there "normal","insert","replace","visual" in contrast to the airline order "normal", "insert", "visual", "replace".

To be consistent and easier to compare, the "replace" and "visual" mode should be swapped.
Even the lightline examples of their github page (https://github.com/itchyny/lightline.vim) use always the order "normal", "insert", "visual", "replace". Thus this order should be used.

[Suggestion] Webstorm Theme

A Webstorm/ InteliJ version of the theme would be lovely.

This theme looks beautiful, thank you for taking the time to create it.

Selection color makes some text hard to read

First of all, thanks for sharing this lovely theme. Amazing work! ๐Ÿ˜

I'm not sure if it's something wrong with my setup, but the selection color in vim makes certain highlights hard to read (def and return are barely visible):

Screenshot 2019-11-01 at 21 41 19

While the purpose of selecting does not strictly go in line with reading what's selected, I was wondering if you'd consider tweaking the selection color a bit.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.