riggaroo / android-arch-components-date-countdown Goto Github PK

Any luck to update this sample to support version 1.1.0? ViewModelProviders.of is deprecated and is no longer supported by latest version.

Hi @riggaroo Rebecca ! First of all, thanks for your contribution Good job!

Is not an issue rather it is something like an improvement for developers who use a stable android studio version like 2.3 and wants compile this project out of android studio 3.0 preview.

I propose create another branch with two little changes to run this project in AS 2.3
(We are not all so risky to use the Android Studio Previews ;) )

  defaultConfig {
      ....
        //jackOptions is deprecated in android Studio 3.0 but this is for educational purposes
        // to compile this project in android studio 2.3 stable version.
        jackOptions {
            enabled true
        }
    } 

buildscript {
    dependencies {
        classpath 'com.android.tools.build:gradle:2.3.2'
    }

It would also be nice if you add on readme file the project only works in Android Studio 3.0 preview.

Its not related to any feature of the application, Im just curious to know the syntax to inject any into the activity/fragment (Android components). not the POJO classes

I'm trying to compile this project on the android-studio-2-3 branch, but the class za.co.riggaroo.datecountdown.injection.DaggerCountdownComponent is missing.

Gradle sync failed: Could not find com.android.tools.build:gradle:3.0.0-alpha7. Searched in the following locations: file:/private/var/folders/d_/vfn7wc5s6k7_9_lgdvmg0wj80000gn/T/AppTranslocation/3D7F470B-A0DA-4462-81CA-D3CD72D0183F/d/Android Studio 3.0 Preview.app/Contents/gradle/m2repository/com/android/tools/build/gradle/3.0.0-alpha7/gradle-3.0.0-alpha7.pom file:/private/var/folders/d_/vfn7wc5s6k7_9_lgdvmg0wj80000gn/T/AppTranslocation/3D7F470B-A0DA-4462-81CA-D3CD72D0183F/d/Android Studio 3.0 Preview.app/Contents/gradle/m2repository/com/android/tools/build/gradle/3.0.0-alpha7/gradle-3.0.0-alpha7.jar https://jcenter.bintray.com/com/android/tools/build/gradle/3.0.0-alpha7/gradle-3.0.0-alpha7.pom https://jcenter.bintray.com/com/android/tools/build/gradle/3.0.0-alpha7/gradle-3.0.0-alpha7.jar Required by: project : Consult IDE log for more details (Help | Show Log) (8s 18ms)

Hi @riggaroo , thanks for this!
A build failure is happening everytime I run androidTest

FAILURE:

 Build failed with an exception.

* What went wrong:
Execution failed for task ':app:transformJackWithJackForDebugAndroidTest'.
com.android.jack.ir.JNodeInternalError: java.lang.Exception: java.lang.IllegalArgumentException: element public abstract void inject(za.co.riggaroo.datecountdown.ui.event.add.AddEventViewModel)  is not a member of the containing type za.co.riggaroo.datecountdown.dao.EventDaoTest.MockCountdownComponent nor any of its superclasses

I think it's related to #google/dagger#468

Your build.gradle file contains obsolete gradle configurations that are going to be removed by the end of 2018.

I suggest replacing the obsolete configurations with the new ones. Please check