riiid / gradle-github-plugin Goto Github PK

The plugin should fail if there were any issues creating the release. Currently, errors are silently ignored.

The README.md file currently says:

prerelease  boolean Optional. true to create a draft (unpublished) release, false to create a published one. Default: false
draft   boolean Optional. true to identify the release as a prerelease. false to identify the release as a full release. Default: false

But it seems like it should be the other way around, like this:

prerelease  boolean Optional. true to identify the release as a prerelease. false to identify the release as a full release. Default: false
draft   boolean Optional. true to create a draft (unpublished) release, false to create a published one. Default: false

ReleaseTask uses the final String BASE_URL to construct the HttpBuilder. It'd be great if BASE_URL were configurable.

I understand that the effort of this enhancement depends on how much the APIs of GitHub.com and GitHub Enterprise differ.

Hi, great plugin, thanks for creating it!

I wanted to use it on a Jenkins plugin I've been working on, which requires JDK6 support. Unfortunately I get the following error:

Error:

FAILURE: Build failed with an exception.

* What went wrong:
java.lang.UnsupportedClassVersionError: co/riiid/gradle/GithubPlugin : Unsupported major.minor version 51.0
> co/riiid/gradle/GithubPlugin : Unsupported major.minor version 51.0

Version:

plugins {
    id "co.riiid.gradle" version "0.4.2"
}

Any chance you could release the next (/future) versions using JDK6 please? I've already tried building it, and it was successful.

@chitacan @importre @gallardo
I was able to update the release and the attachments, is there a way to remove them? i tried removed the tags, but still i find the drafted version and the attachment files.

DELETE /repos/:owner/:repo/releases/:id ?

When the githubRelease task is used under Windows, the assets are uploaded with names that include their full path, but with \ replaced with ., for instance:

https://github.com/WesGilster/Creation-Workshop-Host/releases

Where the release file is named "C.Users.wgilster.git.Creation-Workshop-Host.host.cwh-DEV001.zip"

When run under Linux, the file name contains only the basename, like:

https://github.com/jmkao/Creation-Workshop-Host/releases

I think, but I'm not sure since I've only looked at this a little, that this might be because of the logic in https://github.com/riiid/gradle-github-plugin/blob/master/src/main/groovy/co/riiid/gradle/ReleaseTask.groovy on line 73:

def name = asset.split('/')[-1]

I think that since you have a File object from the previous line, you can use file.getName() to do the same thing in a platform independent way, but I'm not sure how the name object is used downstream, so I'm not sure if this would have any negative consequences.

With later versions of Gradle you can use

plugins {
    id "<your unique ID>"
}

It just requires to be in the central plugin repo of Gradle. See https://plugins.gradle.org

Hi,

When I do an upload of a zip or tar asset generated from the application plugin I get the following response from github:

{message=missing ?url parameter or multipart form data, request_id=B4B5D185:2F09:A4CF6E6:56662C5F}

This is true whether it's from the application plugin or any other file.

The actual github release is actually done through. It's just the subsequent asset uploading that fails. I checked the mime type with your code and it does the right thing (in the zip case it's application/zip).

There isn't much debug code so I can't really tell you where the error is.

here is the config:

github {
    owner = 'xxx-xxx'
    repo = 'abc.abc.abc'
    token = 'XXXXXXXXXXXXXXXXXXX'
    tagName = 'v' + version
    name = 'Version ' + version
    body = 'Autogenerated by Gradle'
    assets = ['build/distributions/' + applicationName + '-' + version + '.zip']
}

the version var comes from the ch.netzwerg.release plugin.

Applying this plugin to the buildSrc of my (netbeans-gradle-project)[https://github.com/kelemen/netbeans-gradle-project] project crashes the build. Though I'm only speculating but I believe that this is because it has a transitive dependency on xerces:xercesImpl:2.9.1 which seems to blow up Gradle when attempting to call an Ant task (the nbm plugin I'm including).