[Bug]: On Windows narrow returns empty strings for items about bit7z HOT 3 CLOSED

Hi!

WC_NO_BEST_FIT_CHARS is not compatible with CP_UTF8

You're right; I must have missed that part in the documentation!

Strangely, this problem has never happened to me in any of my (numerous) tests, and it still does not happen now...

Anyway, I'm working on a fix right now.

Thank you for reporting the issue! 🙏

from bit7z.

Fixed in v4.0.3.

I could not test Windows 10 build 1607 specifically, but I managed to reproduce the problem, even though only on Windows 7.

In my tests, more recent Windows 10 versions, as well as Windows 11, have no problems when passing both CP_UTF8 and WC_NO_BEST_FIT_CHARS to WideCharToMultiByte. That's probably why the issue went unnoticed before your report!

Maybe Microsoft changed the behavior of WideCharToMultiByte at some point, and they forgot to update the documentation accordingly, or it is simply a bug in the more recent versions of Windows.

Anyway, it's better to stick to the documentation, and I fixed the code accordingly.
I apologize for the delay in releasing the fix; testing took some time.
Thank you again!

from bit7z.

Thank you for the wonderful library and quick fix!

from bit7z.