Comments (5)
Due to other fixes, the last statement errors now.
For the first two there was a bug which added an extra 0 to the start of the changepoint list which is why all of them start with 1. For the first example it should just be a mean of 2.33333 as there is 1 segment so mean(c(1,2,4))
is 2.33333.
Then the second example does have a bug as the cpts.full shows that for 1 changepoint it gives an NA value in the table. Thus the best segmentation is still no changepoints but it reports c(0,0,3) as the changepoint locations which is clearly incorrect.
I will need to look further into this bug after the current release (2.2.3) as it only seems to happen with small datasets.
from changepoint.
Hi @rkillick thanks for the update. I confirm an error for the third now, but the first two issues persist.
> changepoint::cpt.mean(c(1,2,4), penalty="Manual", method="BinSeg", pen.value=0, Q=1)@param.est
$mean
[1] 1.000000 2.333333
Warning message:
In BINSEG(sumstat, pen = pen.value, cost_func = costfunc, minseglen = minseglen, :
The number of changepoints identified is Q, it is advised to increase Q to make sure changepoints have not been missed.
> changepoint::cpt.mean(c(1,2,4), penalty="Manual", method="BinSeg", pen.value=0, Q=2)@param.est
$mean
[1] 1.000000 1.000000 2.333333
Warning message:
In BINSEG(sumstat, pen = pen.value, cost_func = costfunc, minseglen = minseglen, :
The number of changepoints identified is Q, it is advised to increase Q to make sure changepoints have not been missed.
> changepoint::cpt.mean(c(1,2,4), penalty="Manual", method="BinSeg", pen.value=0, Q=3)@param.est
Error in BINSEG(sumstat, pen = pen.value, cost_func = costfunc, minseglen = minseglen, :
Q is larger than the maximum number of segments 2.5
from changepoint.
I haven't committed the version to github yet!
from changepoint.
Is this R package under active development and maintenance? Can the package author please upddate old issues and bring them to a logical end? Alternatively if the package author recommends there is another package that has superceded this package, it will be nice we know that. Thanks.
from changepoint.
Yes this package is under active development and maintenance. As you can imagine, when someone is an academic and covid hits then other tasks need to take priority. This is unfortunately what happens when packages are maintained by volunteers and not paid staff.
We have been working on a new major release and so have encorporated these fixes into that. The new term has just started so we are distracted by that but are hoping to have it out early 2023. As stated above, this only happens for very small datasets (toy examples rather than things we encounter in reality if you will) and so isn't a priority for a patch fix.
If you would like to submit a patch fix we would be happy to accept the pull request for others to benefit.
from changepoint.
Related Issues (20)
- NegBin distribution / R-GSOC'21 project? HOT 3
- cpt.meanvar return cost value? HOT 3
- `plot` of Changepoint object is not working HOT 3
- Segment check or residual check? HOT 4
- Q for cpt.meanvar with method=SegNeigh and sumstat = Poisson or Exp HOT 1
- logLik cpt.meanvar output when method="SegNeigh"
- availability of changeppoint.influence library HOT 2
- cpt.meanvar returns an extra changepoint location when locations are called directly HOT 2
- Should cpt.var allow minseglen = 1? HOT 1
- Can cpt.reg class still be used? HOT 1
- SegNeigh/SNIP GSOC project? HOT 2
- cpt.mean doesn't accept a ts object HOT 3
- BinSeg returns zeros in cpts.full matrix
- cpt.mean(method="BinSeg") slower than expected/optimal for large number of data and changes HOT 1
- diagnostic = TRUE does not work HOT 1
- Checking for 1D objects via `is.null(dim(x))` breaks for 1D-arrays HOT 3
- logLik() should return an object of class "logLik" HOT 5
- possible bug in logLik() computation HOT 2
- figure out reasonable calculation for fitted.nhpp() HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from changepoint.