rmcgirr83 / elonw Goto Github PK

Is not compatible with very popular bbcode media (https://www.phpbb.com/customise/db/bbcode/media/)
Please fix.

It looked like it works but now it stoped working, or never did.

Is there a way that I can change something in this code to open in a new tab rather than a window? If there is what exact code? I don't know PHP so I need the exact code changes needed. Thanks.

This extension breaks this http://www.phpbbguru.net/community/viewtopic.php?t=36630 [video] bbcode.

Hi,
I have activated your extension version 1.0.1 for phpbb 3.1 all work fine.
Also in the red notice like here: https://forum.peopleinside.it/viewforum.php?f=2 but on new topic I create link are not open in new window:
https://forum.peopleinside.it/viewforum.php?f=9

Hi @rmcgirr83,

i discovered this potiential issue: https://mathiasbynens.github.io/rel-noopener/.

Do you know?
whatwg/html#290
https://developers.google.com/web/tools/lighthouse/audits/noopener
https://html.spec.whatwg.org/multipage/links.html#link-type-noopener

On these pages, it proposed to use this kind of codes:

• https://www.developpez.com/actu/98441/Un-developpeur-web-recommande-l-utilisation-de-rel-egal-noopener-pour-empecher-les-attaques-par-hameconnage-lancees-en-se-servant-du-window-opener/:

var otherWindow = window.open(); 
otherWindow.opener = null; 
otherWindow.location = URL;

• https://www.blogdev.fr/tutoriels/securite/faille-securite-target-blank:

var nouvelOnglet = window.open('https://www.google.fr', '_blank');
nouvelOnglet.opener = undefined;

Browser compliance: https://caniuse.com/#search=noopener & https://caniuse.com/#search=noreferrer

The future solution: https://www.w3.org/TR/CSP/#directive-disown-opener?

What do you think?

Hi @rmcgirr83,

after activated your extension with the latest snapshot, your last commits seems to be the reason.

I am using phpbb 3.3.3 with board rules 2.1.2. The rules page seems to work fine, but I get errors when the extension is enabled... With the extension off, I don't get the errors.