rmcgirr83 / newtopicsneedapproval Goto Github PK

[phpBB Debug] PHP Warning: in file [ROOT]/vendor/symfony/event-dispatcher/EventDispatcher.php on line 214: call_user_func() expects parameter 1 to be a valid callback, class 'rmcgirr83/newtopicsneedapproval/event/listener' does not have a method 'user_setup_after' is showing above the header on the ACP.

Hello @rmcgirr83,
I think this permission would fit more into the Post group than in the Misc one, since despite the name it collects both post and topic permissions.

The default value for this permission in forums where no role is assigned currently is "No". Probably because there is no value for this permission.

Maybe its better to reverse the workings of the permission and change the description to "New topics need approval". Then the default value of no has no effect.

Hi,

First of all thanks for making this plugin available. Installation went fine. I'm having issues though to get it working.

There are now two permissions:

"Post" => "Can post without approval"
"Misc" => "Can start new topics without approval"

If I get this correctly then the combination of these two permissions should determine which posts should be approved and which not. I tested all combinations and got the following results.

This extension currently seems to be resulting in absolutely no effect.

Hello and thank you for this extension! I'll explain you my case, I'd like to have a subforum with the following features:

1. For a user to create a new topic, it needs approval
2. When an user edits an own post, it doesn't need approval
3. When an user replies to a post he/she has never replied before, then it needs approval

With your extension, I am able to achieve 1 and 2 but not 3. I also tried this extension gn36/phpbb-ext-firstpostedit#8 but it doesn't deal with post approval.

Do you think it makes sense to add 3) as a possibility for your extension? Have control of:

• If user replies to a topic that he/she has not been approved to reply, then it needs approval
• If user replies to an own topic or a topic he/she already have been approved to reply, then it doesn't need approval

What do you think?