rmosolgo / graphql-batch-example Goto Github PK

Hi @rmosolgo ,
Thanks for all the effort you are putting in graphql related gems.

This example has been quite helpful to me but I have no clue about how to update it to work with latest graphql-batch :(
Would you consider updating this example or giving some hints to do so myself?

I am working on an application that implements a ForeignKeyLoader similar to the one you have written in good_schema/foreign_key_loader.rb

However, I noticed that when this loader is used in your schema.rb, you call it as such:

ForeignKeyLoader.for(MTG::Card, :expansion_id).load([obj.id])

Is there an advantage to wrapping obj.id in an array? I see that the ForeignKeyLoader breaks if these are not present due to the line:

matching_records = records.select { |r| foreign_value_set.include?(r.send(@foreign_key)) }

in the loader.

If we change the .include? to ==, the array is no longer needed. Is there another advantage to wrapping the argument in an array that I may not be seeing?

Thanks!