Giter VIP home page Giter VIP logo

rar's People

Contributors

atul9 avatar kestein avatar lingman avatar roba1993 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

rar's Issues

`nom::be_u32` is used instead of the `nom::le_u32`

According to the original unrar sources Little-endian should be used there:

RAR/src/head_block.rs

Lines 152 to 161 in b84da66

/// get a base header
named!(base_header(&[u8]) -> (HeadBlock),
do_parse!(
crc: be_u32 >>
size: vint >>
typ: vint >>
flags: vint >>
(HeadBlock::new(crc, size, typ.into(), flags.into()))
)
);

RAR/src/file_block.rs

Lines 68 to 79 in b84da66

if file.flags.time {
let (i, mtime) = be_u32(input)?;
input = i;
file.mtime = mtime;
}
// check for file crc data
if file.flags.crc {
let (i, crc) = be_u32(input)?;
input = i;
file.data_crc = crc;
}

`FileEncryptionBlock` doesn't contain the `init` member

According to the original code of the unrar utility, initialization vectors are located before each encrypted block (and all blocks are encrypted after occurrence of the FileEncryptionBlock).

FileEncryptionBlock (in the original that block is called CRYPT block) doesn't contain the initialization vector, so this code is wrong:

RAR/src/extra_block.rs

Lines 217 to 222 in 954bd98

// parse salt value
let (inp, salt) = take!(inp, 16)?;
// parse init value
let (mut inp, init) = take!(inp, 16)?;
// parse pw check value
let mut pw_check = [0; 12];

Lines 219-220 should be removed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.