robdennis / lambic Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 1.0 6.34 MB

javascript widget for laying out a Magic: The Gathering deck or cube

JavaScript 99.59% CSS 0.30% Python 0.07% Shell 0.03% Ruby 0.01%

lambic's People

Contributors

Stargazers

Watchers

Forkers

jacobangel

lambic's Issues

mouseover card pictures don't work for cards with certain special characters

for example, "Man-'o-War" is currently searching for a picture with a URL that cuts off after "Man-"

accept lower case / ascii card names in the sidebar

currently, the sidebar textarea is naive enough to require the actual capitalization (and probably doesn't handle ascii equivalent characters either)

copying and pasting a list from some website has a good chance of throwing a stacktrace due to either bad data or cards types that are unhandled

http://pastebin.com/WhHGZM4J

TypeError: Cannot read property 'length' of undefined
    at Object._checkForMultiColor (http://127.0.0.1:8000/app/js/services.js:194:46)
    at Object._checkForColor (http://127.0.0.1:8000/app/js/services.js:231:33)
    at http://127.0.0.1:8000/app/js/services.js:368:50
    at Array.forEach (native)
    at Object.forEach (http://127.0.0.1:8000/app/lib/angular/angular.js:130:11)
    at http://127.0.0.1:8000/app/js/services.js:354:33
    at Array.forEach (native)
    at Object.forEach (http://127.0.0.1:8000/app/lib/angular/angular.js:130:11)
    at http://127.0.0.1:8000/app/js/services.js:343:29
    at Array.forEach (native) angular.js:5754

refactor using lodash

there's a lot of unnecessary hoops jumped through before I knew lodash was an available option

Is there a license here?

I ended up forking this project, but there's no license; what's it going to be? http://choosealicense.com/

things should be sortable by what colors of mana they can be used for

this is particular importance for lands, since it's not helpful to list them in alphabetical order in one big pile.

add commander 2013

it's on gatherer

the button for making the text area contents equal to the pool can be below the screen

bottom depending on zoom and resolution:
https://twitter.com/tailsy/status/412451915352788992/photo/1

If there's content in the sidebar, the user should be prompted before leaving the page to ensure there's no lost work

the use case for lambic includes people hand-entering their list and then trying to saving that / share it somewhere.

Since lambic itself doesn't provide a method of storing this data, it's probably better to at least prompt before leaving if there's content there.

refactor to store all_cards as an object keyed by card name instead of array

this would mean that tests wouldn't have to construct the object on setup. In practice the means the test run about 4-5 times faster, which is nice.

"Quick Add" typeahead should show the mana cost of the suggested cards

the cost is an important part of remember what a particular card is doing, and unlike the rules text, it's compact enough to be part of the selection.